Walkthrough

The PR includes minor code refactoring and new test coverage. It reorders a variable declaration in the idempotency middleware response parser, adjusts formatting in the corresponding test file, renames a loop variable from subApp to mountedApp in mount functions, and adds two new test functions to validate OnMount hook propagation in nested mount scenarios.

Changes

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

• Variable renaming in mount.go is a straightforward refactor with consistent application
• New test functions in mount_test.go require verification of test logic and hook behavior validation, but follow established test patterns
• Formatting and minor reordering changes are cosmetic and low-risk

Suggested reviewers

• sixcolors
• ReneWerner87
• efectn

Poem

🐰 A rename brings clarity to the mount,
subApp becomes mountedApp—a trivial flaunt.
Nested hooks dance in tests anew,
Parent refs flow where they're due. ✨

Pre-merge checks and finishing touches

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Summary of Changes

Hello @gaby, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on enhancing the mount functionality by improving code readability through variable renaming and adding comprehensive tests for nested application and group mount hooks. It also includes minor, likely linter-driven, reordering of elements in msgp generated files. Please note that the actual code changes do not align with the PR title 'Revert lint target update', which suggests a different intent related to golangci-lint configuration.

Highlights

• Refactored Mount Methods: Renamed loop variables from subApp to mountedApp in both App.Mount and Group.Mount methods within mount.go for improved clarity and readability.
• Added Nested Mount Hook Tests: Introduced new test cases, Test_App_Mount_NestedHooks and Test_Group_Mount_NestedHooks, in mount_test.go to thoroughly verify the behavior of OnMount hooks when applications and groups are nested.
• Minor Code Generation Adjustments: Applied small reordering changes in middleware/idempotency/response_msgp.go and middleware/idempotency/response_msgp_test.go, primarily affecting the placement of the package declaration relative to the // Code generated by ... comment, and a variable declaration order in UnmarshalMsg.