🧹 chore: Fix autolabeler for release-drafter#3865
Conversation
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary of ChangesHello @gaby, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request streamlines the automated release process by updating the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Removed version header and 'What's Changed' section from release drafter template.
There was a problem hiding this comment.
Code Review
This pull request fixes the autolabeler configuration for release-drafter by updating its syntax and also improves the template for autogenerated release notes. The changes are positive, particularly the more reliable method for labeling dependency updates. However, I have identified a couple of areas in the regular expressions for labeling bugs and updates that could be refined to prevent mislabeling of pull requests. My suggestions aim to restore some of the previous matching logic for more accurate labeling.
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the autolabeler configuration format for release-drafter and improves the release notes template. The autolabeler configuration has been updated from the nested matcher: structure to the correct direct property format, and the release template now includes better formatting with documentation links and a "What's Changed" section.
Key Changes
- Fixed autolabeler format by removing nested
matcher:structure and using directtitle:,files:, andbranch:properties - Removed '📝 Proposal' label from version-resolver minor labels
- Enhanced release template with version header, documentation links, and Discord link
| @@ -39,7 +39,6 @@ version-resolver: | |||
| minor: | |||
| labels: | |||
| - '✏️ Feature' | |||
There was a problem hiding this comment.
The '📝 Proposal' label is still referenced in the categories section (line 16) but has been removed from the version-resolver. This creates an inconsistency where PRs with this label will appear in the "🚀 New" category but won't affect version calculation.
Consider also removing '📝 Proposal' from line 16 in the categories section, or add it back to the version-resolver if proposal PRs should still bump the minor version.
| - '✏️ Feature' | |
| - '✏️ Feature' | |
| - '📝 Proposal' |
| title: '/(bump|dependencies)/i' | ||
| files: | ||
| - 'go.mod' | ||
| - 'go.sum' |
There was a problem hiding this comment.
The word "missing" has been moved from the '☢️ Bug' pattern to the '🧹 Updates' pattern. However, commits with "missing" in the title typically indicate bug fixes (e.g., "fix missing validation", "add missing error check"), not general updates or improvements.
Consider moving "missing" back to the '☢️ Bug' pattern on line 69 to ensure bug fixes are properly categorized.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3865 +/- ##
=======================================
Coverage 91.69% 91.69%
=======================================
Files 115 115
Lines 9819 9819
=======================================
Hits 9004 9004
Misses 516 516
Partials 299 299
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Words can be tweaked in the future, next PR will be to enforce the title of PRs |
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.50.
| Benchmark suite | Current: 69a6379 | Previous: 813404a | Ratio |
|---|---|---|---|
Benchmark_Compress_Levels/Zstd_LevelDefault - B/op |
1 B/op |
0 B/op |
+∞ |
This comment was automatically generated by workflow using github-action-benchmark.
Description
autolabelerformatting, the one for release-drafter is different.