Walkthrough

Introduces a unwrapType() helper function to dereference pointer types and updates field type analysis in the mapping logic to use unwrapped types instead of direct pointer inspection. Extends test coverage for pointer slices, nested structs, and pointer-to-pointer scenarios in binding operations.

Changes

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

• Pay attention to the unwrapType() implementation and ensure pointer dereferencing handles all edge cases correctly
• Verify all call sites where field types are inspected now use the unwrapped type consistently
• Review test cases to confirm they cover the new pointer unwrapping scenarios comprehensively

Suggested labels

☢️ Bug, v3

Suggested reviewers

• sixcolors
• efectn
• ReneWerner87

Poem

🐰 Pointers unwrapped, no more confusion,
Through layers of types, we seek the illusion,
Nested structs and slices align,
Reflection now works by design! ✨

Pre-merge checks and finishing touches

Learnt from: efectn
Repo: gofiber/fiber PR: 3162
File: hooks_test.go:228-228
Timestamp: 2024-12-13T08:14:22.851Z
Learning: In Go test files, prefer using the `require` methods from the `testify` package for assertions instead of manual comparisons and calls to `t.Fatal` or `t.Fatalf`.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Summary of Changes

Hello @gaby, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves an issue where the binder failed to correctly process and split values for fields that are pointer-backed slices. By introducing a mechanism to unwrap pointer types during field metadata construction, the binder can now accurately identify the underlying slice types. This enhancement ensures robust data binding for complex Go struct definitions that leverage pointers, improving the reliability of query parameter parsing.

Highlights

• Pointer Type Unwrapping: Introduced a new utility function, unwrapType, to recursively resolve the underlying type of a field, effectively handling pointer indirection.
• Binder Field Metadata Correction: Updated the buildFieldInfo function to utilize unwrapType, ensuring that the binder correctly identifies the kind of pointer-backed slice fields for proper splitting.
• Expanded Test Coverage: Added new test cases to equalFieldType in binder/mapping_test.go to specifically cover scenarios involving pointer slices and nested pointer structs, validating the type comparison logic.
• Query Binder Regression Test: Included a new regression test, Test_QueryBinder_Bind_PointerSlices, to confirm that the QueryBinding mechanism correctly binds comma-separated values into pointer-backed slices, including those within nested structs, when splitting is enabled.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.13%. Comparing base (ff04aa0) to head (1efdf72).
⚠️ Report is 1 commits behind head on main.

@@            Coverage Diff             @@
##             main    #3844      +/-   ##
==========================================
- Coverage   92.18%   92.13%   -0.06%     
==========================================
  Files         115      115              
  Lines        9754     9760       +6     
==========================================
  Hits         8992     8992              
- Misses        484      489       +5     
- Partials      278      279       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.