ctx.go (3)

425-439: Consider a dedicated string copy helper.

The pattern c.app.getString([]byte(key)) and c.app.getString([]byte(val)) converts string → bytes → string, which adds unnecessary overhead since key and values are already strings from the multipart form map.

Consider adding a dedicated helper like c.app.copyString(str string) string that directly copies strings when immutability is enabled, avoiding the intermediate byte slice conversion.

Note: Similar efficiency concerns were raised in past review comments for comparable patterns.

---

1080-1084: Consider a dedicated string copy helper.

Line 1082 uses c.app.getString([]byte(value)) where value is already a string from route parameters. This string → bytes → string conversion adds unnecessary overhead.

A dedicated c.app.copyString(str string) string helper would avoid the intermediate byte slice allocation and improve efficiency for this common pattern.

Note: This mirrors efficiency concerns raised in past review comments.

---

1837-1841: Consider a dedicated string copy helper.

The pattern c.app.getString([]byte(subdomain)) converts string → bytes → string where subdomain is already a string from strings.Split(). This adds unnecessary conversion overhead.

Using a dedicated string copy helper would be more efficient for this immutability enforcement.

Note: Consistent with efficiency concerns from past review comments.

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Learnt from: arturmelanchyk
Repo: gofiber/fiber PR: 3768
File: client/request.go:162-166
Timestamp: 2025-09-28T17:39:26.644Z
Learning: In fasthttp-based code like gofiber, using utils.UnsafeString(key) instead of string(key) is acceptable when values are used immediately within the same call stack and not stored for later use, as it avoids allocations and aligns with fasthttp's zero-allocation design philosophy.

Learnt from: ReneWerner87
Repo: gofiber/fiber PR: 3161
File: app.go:923-932
Timestamp: 2024-11-15T07:56:21.623Z
Learning: In the Fiber framework, breaking changes are acceptable when moving from version 2 to version 3, including modifications to method signatures such as in the `Test` method in `app.go`.

Learnt from: ReneWerner87
Repo: gofiber/fiber PR: 0
File: :0-0
Timestamp: 2024-12-01T10:28:36.011Z
Learning: Fiber currently supports square bracket notation in form data with 'application/x-www-form-urlencoded' content type, but this feature is not available for multipart form data. The implementation for form-urlencoded is in ctx.go (BodyParser method), while multipart form data handling needs enhancement to support this feature.

ctx_test.go (1)

2962-3081: LGTM! Comprehensive immutability test that properly validates the fix.

The test effectively verifies that context values remain immutable across request lifecycles by:

1. Capturing snapshots of context values during handler execution
2. Processing a second request with different data (causing context reuse)
3. Asserting the first snapshot retains its original values

The coverage is thorough, testing Method, Path, OriginalURL, BaseURL, Protocol, Hostname, route params, query strings, cookies, headers, IP/IPs, subdomains, body, and route path.

Optional enhancements to consider:

1. Subtests for clarity: Consider organizing the assertions into subtests (e.g., t.Run("first_request_data", ...) and t.Run("second_request_data", ...)).

2. Concurrent access: Issue #3236 specifically mentions goroutines. While this test validates immutability across sequential requests, consider adding a companion test that spawns goroutines to access captured values concurrently and verifies no data races occur (potentially with -race flag).

3. Documentation: A brief comment at the top explaining this validates immutability guarantees per issue #3236 would help future maintainers.

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Learnt from: gaby
Repo: gofiber/fiber PR: 3193
File: middleware/adaptor/adaptor.go:111-111
Timestamp: 2024-11-10T23:44:13.704Z
Learning: In the `middleware/adaptor/adaptor.go` file of the Fiber framework, when updating context handling, replacing `c.Context()` with `c.RequestCtx()` is appropriate to access the `fasthttp.RequestCtx`.

Learnt from: gaby
Repo: gofiber/fiber PR: 3193
File: middleware/cache/cache_test.go:897-897
Timestamp: 2024-11-08T04:10:42.990Z
Learning: In the Fiber framework, `Context()` is being renamed to `RequestCtx()`, and `UserContext()` to `Context()` to improve clarity and align with Go's context conventions.

Learnt from: ReneWerner87
Repo: gofiber/fiber PR: 3161
File: app.go:923-932
Timestamp: 2024-11-15T07:56:21.623Z
Learning: In the Fiber framework, breaking changes are acceptable when moving from version 2 to version 3, including modifications to method signatures such as in the `Test` method in `app.go`.

Learnt from: efectn
Repo: gofiber/fiber PR: 3162
File: app_test.go:893-895
Timestamp: 2024-11-29T12:37:27.581Z
Learning: In the `Test_App_ShutdownWithContext` function in `app_test.go`, the `clientDone` channel is used to synchronize the client's request completion before proceeding, eliminating the need for additional `time.Sleep` calls.