client/client.go (2)

705-712: Add json.RawMessage fast‑path

json.RawMessage (defined type over []byte) won’t match case []byte in a type switch, so it currently falls into SetJSON. If the intent is to allow raw JSON bytes too, add an explicit case.

   switch v := cfg.Body.(type) {
+  case json.RawMessage:
+    req.SetRawBody(v)
   case []byte:
     req.SetRawBody(v)
   case string:
     req.SetRawBody([]byte(v))
   default:
     req.SetJSON(cfg.Body)
   }

---

705-712: Content‑Type with raw bodies

When using []byte/string, Content‑Type is not auto‑set (unlike SetJSON). This may break callers who relied on implicit application/json for strings. Either:

• set a sensible default if header is absent (text/plain; charset=utf-8 for string, application/octet-stream for []byte), or
• clearly document that callers must set Content‑Type explicitly when passing raw bodies.

Add/adjust tests and release notes to reflect this change.

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

client/client_test.go (1)

2091-2133: Consider adding edge case tests for body handling.

The current tests provide solid coverage for the happy path scenarios (string, []byte, struct, map). However, consider adding tests for edge cases to ensure robust handling:

• nil body value
• Empty string ""
• Empty byte slice []byte("") or []byte{}
• Potentially other types that might be passed (e.g., io.Reader if supported)

These edge cases could reveal boundary conditions in the implementation.

Would you like me to generate additional test cases for these edge cases?

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

client/client_test.go (4)

2102-2109: Consider edge case tests for byte slice bodies.

The test correctly verifies that []byte bodies are stored as-is. Consider adding tests for edge cases:

• nil byte slice: Config{Body: []byte(nil)}
• Empty byte slice: Config{Body: []byte{}}

These edge cases ensure robust handling of boundary conditions.

---

2126-2137: Test verifies storage but not JSON marshaling for maps.

Similar to the struct test, this verifies that map bodies are stored internally but doesn't verify the actual JSON marshaling and sending behavior. The complete flow should be tested to ensure maps are correctly marshaled to JSON and sent in HTTP requests.

---

2091-2137: Add tests verifying mutual exclusivity of Body, FormData, and File.

The implementation correctly enforces priority through early returns (Body returns at line 713, preventing FormData/File processing). However, the current test suite only verifies individual body types—not that setting Body actually prevents FormData and File from being processed.

Add integration tests for mutual exclusivity:

• Body set with FormData present → Body used, FormData ignored
• Body set with File present → Body used, File ignored
• FormData set with File present → FormData used, File ignored

This ensures the documented priority ("Body > FormData > File") is testable and prevents regressions.

---

2091-2100: Test is correct; no changes needed. Consider adding edge case tests as optional enhancement.

The test properly verifies that string bodies are converted to []byte. Verification confirms that the implementation calls SetRawBody([]byte(v)) for string bodies, and the test correctly validates this by checking the resulting req.body value.

Optional improvement: Consider adding edge case tests for:

• Empty string: ""
• Unicode/multibyte characters: "测试🎉"
• Large strings (if performance is a concern)

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro