Reviewing files that changed from the base of the PR and between 8127494 and 68f2e72.

• .github/workflows/linter.yml is excluded by !**/*.yml
• .golangci.yml is excluded by !**/*.yml

• app_test.go (7 hunks)
• bind_test.go (4 hunks)
• binder/binder_test.go (1 hunks)
• binder/mapping_test.go (1 hunks)
• client/client_test.go (11 hunks)
• client/core.go (1 hunks)
• client/hooks.go (1 hunks)
• client/hooks_test.go (4 hunks)
• client/request.go (3 hunks)
• client/request_test.go (7 hunks)
• ctx.go (1 hunks)
• ctx_test.go (18 hunks)
• extractors/extractors_test.go (2 hunks)
• helpers.go (2 hunks)
• helpers_test.go (2 hunks)
• hooks_test.go (1 hunks)
• listen.go (2 hunks)
• listen_test.go (1 hunks)
• log/default.go (1 hunks)
• middleware/adaptor/adaptor_test.go (1 hunks)
• middleware/cache/cache_test.go (1 hunks)
• middleware/compress/compress_test.go (12 hunks)
• middleware/cors/cors.go (1 hunks)
• middleware/cors/cors_test.go (22 hunks)
• middleware/csrf/config_test.go (1 hunks)
• middleware/envvar/envvar_test.go (2 hunks)
• middleware/helmet/helmet_test.go (4 hunks)
• middleware/idempotency/idempotency_test.go (1 hunks)
• middleware/keyauth/keyauth_test.go (2 hunks)
• middleware/limiter/limiter_test.go (7 hunks)
• middleware/logger/default_logger.go (1 hunks)
• middleware/logger/logger_test.go (3 hunks)
• middleware/logger/tags.go (3 hunks)
• middleware/recover/recover.go (1 hunks)
• middleware/session/session_test.go (6 hunks)
• middleware/session/store_test.go (4 hunks)
• middleware/static/static_test.go (6 hunks)
• mount_test.go (1 hunks)
• path.go (5 hunks)
• path_test.go (1 hunks)
• req.go (5 hunks)
• res.go (3 hunks)
• router_test.go (2 hunks)
• state_test.go (1 hunks)

• ctx.go
• path_test.go
• app_test.go
• mount_test.go

helpers_test.go (1)

21-21: LGTM! Test assertion improvements align with best practices.

The change from require.Equal(t, "", ...) to require.Empty(t, ...) improves test readability and semantics. require.Empty is more expressive and aligns with testifylint recommendations enforced by golangci-lint.

Also applies to: 23-23, 25-29, 35-35, 57-58, 63-63, 71-71

middleware/csrf/config_test.go (1)

162-162: LGTM! Idiomatic assertion style.

The change from require.Equal(t, "", chained.Key) to require.Empty(t, chained.Key) is more idiomatic and aligns with testify best practices for empty-value assertions. This likely addresses a golangci-lint rule (e.g., testifylint) enforcing consistent empty checks.

middleware/adaptor/adaptor_test.go (1)

237-237: LGTM!

The change from explicit type declaration to short variable declaration is idiomatic Go and aligns with best practices. This likely resolves a golangci-lint warning (e.g., S1021: should omit type from declaration).

middleware/cache/cache_test.go (1)

913-913: LGTM! Test assertion style improved.

The change from checking equality with an empty string to using require.Empty() is more idiomatic for testify assertions and aligns with the PR's objective to address golangci-lint issues. The test logic remains functionally equivalent—both lines correctly verify that HEAD responses return empty bodies per HTTP specification.

Also applies to: 920-920

middleware/keyauth/keyauth_test.go (1)

162-163: LGTM! Explicit default case improves clarity.

The addition of an explicit default branch for paramExtractorName makes the code more maintainable and satisfies exhaustive switch-case linting rules. Since param-based extraction configures the URL path (lines 132-134) rather than headers or body, this no-op default accurately documents the intentional absence of header/body setup.

extractors/extractors_test.go (2)

312-312: LGTM! Improved test assertion.

The change from require.Equal(t, "", ...) to require.Empty(t, ...) is more idiomatic and aligns with golangci-lint best practices for Go 1.25.0. This assertion style is clearer and handles nil values correctly.

---

659-659: LGTM! Consistent test assertion improvement.

This change mirrors the improvement at line 312, ensuring consistency across the test file. Using require.Empty(t, ...) is the idiomatic approach for emptiness checks.

middleware/envvar/envvar_test.go (2)

24-24: LGTM! Improved assertion style.

Using require.Empty is more idiomatic than comparing to an empty string and clearly expresses the intent to check for emptiness. This change aligns with testifylint best practices.

---

119-119: LGTM! Improved assertion style.

Using require.Empty is more idiomatic than comparing to an empty string. This change clearly expresses the intent to verify that the HEAD request returns no body and aligns with testifylint best practices.

middleware/recover/recover.go (1)

11-13: LGTM! Cleaner panic handler implementation.

The refactor from fmt.Sprintf + write to direct fmt.Fprintf(os.Stderr, ...) eliminates an intermediate string allocation and removes the need for the nolint:errcheck directive. The output remains identical, and the code is now more idiomatic and efficient.

res.go (1)

371-371: LGTM: Consistent refactor.

The change from r.c.DefaultReq.Accepts(...) to r.c.Accepts(...) is consistent with the refactoring in the Format method and improves API consistency.

middleware/session/store_test.go (2)

22-66: LGTM! Public API field path updated correctly.

The test correctly exercises session ID extraction via cookie, header, and URL query using the new top-level store.Extractor.Key field path, aligning with the Store API refactor.

---

78-93: LGTM! Security regression test updated correctly.

The test properly validates that invalid session IDs trigger regeneration, using the updated store.Extractor.Key field path.

middleware/session/session_test.go (4)

768-769: LGTM! Public API field path updated correctly.

The test correctly forces IdleTimeout to a longer value using the new top-level store.IdleTimeout field to verify that AbsoluteTimeout takes precedence, aligning with the Store API refactor.

---

898-898: LGTM! Improved assertion style.

Using require.Empty to verify the absence of the session_id header after destruction is more idiomatic than an equality check.

---

1033-1035: LGTM! Improved cookie attribute validation.

Using strings.SplitSeq with range iteration to verify cookie attributes order-independently is more robust than substring matching and correctly handles attribute ordering variations.

---

1182-1183: LGTM! Improved assertion style.

Using require.Empty to verify the absence of session_id in both response and request headers after reset is more idiomatic than equality checks.

path.go (2)

356-364: LGTM! Lint fix for exhaustive switch.

The explicit default case satisfies linter requirements (likely exhaustive or similar) without changing behavior. The "do nothing" comment clearly documents the intent.

---

504-506: LGTM! Improved bounds checking.

The condition now explicitly checks i > partLen before slicing, preventing potential out-of-bounds panics. The short-circuit OR operator ensures safe evaluation.

hooks_test.go (1)

22-38: LGTM!

The assertion update from require.Equal(t, "", r.Name) to require.Empty(t, r.Name) improves readability and aligns with idiomatic test style.

binder/mapping_test.go (1)

379-398: LGTM!

The assertion update from require.Equal(t, "", m["empty"]) to require.Empty(t, m["empty"]) improves readability and aligns with idiomatic test style.

middleware/logger/default_logger.go (1)

38-47: LGTM!

The refactor from buf.WriteString(fmt.Sprintf(...)) to fmt.Fprintf(buf, ...) reduces allocations by writing directly to the buffer without intermediate string allocation, aligning with other logging components in the repository.

binder/binder_test.go (1)

72-83: LGTM!

The assertion update from require.Equal(t, "", m2["empty"]) to require.Empty(t, m2["empty"]) improves readability and aligns with idiomatic test style.

client/core.go (1)

256-256: LGTM!

The new exported error variable ErrBodyTypeNotSupported is well-named with a clear error message, enabling explicit error handling for unsupported body types in client/hooks.go.

middleware/static/static_test.go (5)

93-93: LGTM!

The assertion update to require.Empty for the Cache-Control header check improves readability and aligns with idiomatic test style.

---

137-137: LGTM!

The assertion update to require.Empty for the Cache-Control header check improves readability and aligns with idiomatic test style.

---

167-177: LGTM!

The assertion updates to require.Empty for the Cache-Control header checks improve readability and align with idiomatic test style.

---

795-795: LGTM!

The assertion update to require.Empty for the Content-Encoding header check improves readability and aligns with idiomatic test style.

---

826-826: LGTM!

The assertion update to require.Empty for the Content-Encoding header check improves readability and aligns with idiomatic test style.

middleware/logger/logger_test.go (2)

137-137: LGTM: Test assertion style improvement.

The change from require.Equal(t, "", buf.String()) to require.Empty(t, buf.String()) is more idiomatic and aligns with the PR-wide test assertion improvements.

---

833-835: LGTM: Concurrency pattern modernized.

The change from manual wg.Add(1) and wg.Done() to wg.Go(func() {...}) is cleaner and less error-prone. This aligns with similar concurrency improvements throughout the test suite.

state_test.go (1)

54-54: LGTM: Test assertion style improvements.

The changes from require.Equal(t, "", s) to require.Empty(t, s) are more idiomatic and align with the PR-wide test assertion improvements. The functional behavior remains unchanged.

Also applies to: 59-59

middleware/cors/cors.go (1)

50-50: LGTM: Simplified initialization logic.

The change from a two-step initialization to a single boolean expression is cleaner and more concise while maintaining the same logical behavior.

client/request.go (3)

538-547: LGTM: Control flow restructured but functionally equivalent.

The switch statement restructuring maintains the same logic:

• Empty name still matches by base path
• Non-empty name matches by equality
• Default case continues iteration

---

922-922: LGTM: Simplified method call.

The change from f.Args.Del(v) to f.Del(v) is cleaner. Since FormData wraps *fasthttp.Args and likely has a Del method that delegates to Args.Del, this is an improvement.

---

716-716: Resolve: Header.All() correctly delegates to fasthttp.RequestHeader.All The embedded *fasthttp.RequestHeader promotes its All() method, so h.All() returns the same data as h.RequestHeader.All().

client/request_test.go (1)

459-459: LGTM: Test assertion style improvements.

All changes from require.Equal(t, "", ...) to require.Empty(t, ...) are more idiomatic and align with the PR-wide test assertion improvements. Based on learnings: prefer using require methods from the testify package for assertions.

Also applies to: 563-563, 578-579, 925-925, 979-979, 1625-1625, 1779-1779

listen_test.go (1)

662-669: LGTM: Concurrency pattern modernized.

The change from manual wg.Add(1) and wg.Done() to wg.Go(func() {...}) is cleaner and less error-prone. This aligns with similar concurrency improvements throughout the test suite.

middleware/compress/compress_test.go (1)

183-183: LGTM: Test assertion style improvements.

All changes improve test assertion idioms:

• Replacing require.Equal(t, "", ...) with require.Empty(t, ...) for empty string checks
• Replacing require.Equal(t, len(body), len(filedata)) with require.Len(t, body, len(filedata)) for length checks

These changes align with the PR-wide test assertion improvements and make the test intent clearer.

Also applies to: 188-188, 412-412, 449-449, 471-471, 493-493, 513-513, 532-532, 553-553, 574-574, 595-595, 630-630, 651-651

listen.go (1)

301-302: LGTM! Context-aware listening improves graceful shutdown.

Replacing direct net.Listen with net.ListenConfig{}.Listen(cfg.GracefulContext, ...) enables context-aware listener creation for non-TLS paths. This respects cancellation from cfg.GracefulContext and aligns with the graceful shutdown flow initiated at line 216.

helpers.go (1)

447-448: LGTM! Default case documents existing behavior.

The added default case explicitly documents that all other characters are ignored in the quoted parsing path. This clarifies intent without changing logic.

router_test.go (1)

1042-1042: LGTM! Empty check is more idiomatic.

Replacing the empty string comparison with require.Empty is consistent with the broader test suite migration and is more explicit about checking for emptiness.

middleware/limiter/limiter_test.go (2)

239-239: LGTM! Using require.NoError in goroutines improves test reliability.

Switching from assert.NoError to require.NoError inside concurrent test goroutines ensures immediate test failure on error, preventing misleading subsequent assertions and potential race conditions.

Also applies to: 243-243, 278-278, 282-282, 320-320, 324-324, 361-361, 365-365

---

1006-1008: LGTM! Empty checks are more explicit for header absence.

Replacing direct empty string comparisons with require.Empty for header checks when DisableHeaders is true is more idiomatic and clearly expresses the intent that these headers should not be present.

Also applies to: 1018-1021

middleware/cors/cors_test.go (1)

51-51: LGTM! Empty checks improve test clarity.

Replacing direct empty string comparisons with require.Empty for header assertions is more idiomatic and clearly expresses the intent that these headers should be absent. This aligns with the broader test suite migration to explicit emptiness checks.

Also applies to: 83-83, 115-116, 126-127, 184-184, 195-195, 263-263, 364-364, 377-377, 390-390, 532-532, 611-611, 628-628, 643-644, 692-692, 745-745, 1029-1029, 1032-1032, 1042-1042, 1057-1057, 1072-1072, 1088-1088, 1105-1105

middleware/helmet/helmet_test.go (1)

26-26: LGTM! Empty checks are more explicit for header absence.

Replacing direct empty string comparisons with require.Empty for security header assertions is more idiomatic and clearly expresses the intent that these headers should be absent in the tested scenarios. This aligns with the broader test suite migration to explicit emptiness checks.

Also applies to: 28-28, 83-83, 151-151, 185-185, 233-233

client/hooks_test.go (3)

202-205: LGTM! Default case improves test robustness.

Adding a default case with t.Fatalf ensures the test fails immediately if an unexpected query parameter value is encountered, providing clearer diagnostic information and preventing silent test failures.

---

415-415: LGTM! Empty checks are more idiomatic.

Replacing direct empty string comparisons with require.Empty for cookie value assertions is consistent with the broader test suite migration and more clearly expresses the intent.

Also applies to: 437-437

---

624-624: LGTM! Direct buffer write reduces allocations.

Replacing fmt.Sprintf with fmt.Fprintf for writing formatted logs directly to the buffer eliminates intermediate string allocation, improving efficiency in the test logger.

bind_test.go (1)

220-220: LGTM: Idiomatic assertion style.

The switch from require.Equal(t, "", field) to require.Empty(t, field) improves test readability and aligns with Go testing best practices. This is likely addressing a golangci-lint recommendation for more idiomatic empty-value assertions.

Also applies to: 477-477, 1141-1141, 1660-1660

Reviewing files that changed from the base of the PR and between b2d22c2 and 0c8342f.

• path.go (5 hunks)
• req.go (5 hunks)
• res.go (2 hunks)

• res.go
• req.go

path.go (2)

503-506: LGTM: const-part guard with optional slash is correct.

The HasOptionalSlash branch then i > partLen || detectionPath[:i] != segment.Const fallback reads clean and is correct.

---

516-524: Skipping constraint checks for omitted optional params is correct.

if !segment.IsOptional || i != 0 avoids validating empty optionals (e.g., :id<int>?). Please ensure tests cover both omitted and present cases with constraints.