The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

res.go (1)

478-478: Potential inconsistency in CBOR method

In the CBOR method, line 478 uses response.SetBodyRaw(raw) while other encoder methods like JSON (line 438) and MsgPack (line 458) also use response.SetBodyRaw(raw). However, I notice there's an inconsistent indentation or alignment that might have been introduced during refactoring.

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

Learnt from: gaby
PR: gofiber/fiber#3193
File: middleware/adaptor/adaptor.go:111-111
Timestamp: 2024-11-10T23:44:13.704Z
Learning: In the `middleware/adaptor/adaptor.go` file of the Fiber framework, when updating context handling, replacing `c.Context()` with `c.RequestCtx()` is appropriate to access the `fasthttp.RequestCtx`.

Learnt from: gaby
PR: gofiber/fiber#3193
File: middleware/cache/cache_test.go:897-897
Timestamp: 2024-11-08T04:10:42.990Z
Learning: In the Fiber framework, `Context()` is being renamed to `RequestCtx()`, and `UserContext()` to `Context()` to improve clarity and align with Go's context conventions.

Learnt from: gaby
PR: gofiber/fiber#3193
File: middleware/adaptor/adaptor.go:111-111
Timestamp: 2024-11-10T23:44:13.704Z
Learning: In the `middleware/adaptor/adaptor.go` file of the Fiber framework, when updating context handling, replacing `c.Context()` with `c.RequestCtx()` is appropriate to access the `fasthttp.RequestCtx`.

Learnt from: sixcolors
PR: gofiber/fiber#3016
File: middleware/csrf/csrf_test.go:188-193
Timestamp: 2024-09-25T15:57:10.221Z
Learning: In the Fiber framework tests, using `ctx.Response.Header.Cookie` may not be suitable for parsing cookies from the response header, as it requires a `*Cookie` and fills it rather than returning a string value; thus, manual parsing of the `Set-Cookie` header may be necessary.

Learnt from: gaby
PR: gofiber/fiber#3170
File: ctx.go:1825-1826
Timestamp: 2024-10-16T14:00:50.724Z
Learning: In the Fiber framework, the `IsProxyTrusted()` function returns `true` when `TrustProxy` is `false`, maintaining compatibility with version 2 behavior.

req.go (6)

92-92: Nit: simplify condition in multi-encoding decode path.

The decodesRealized > 0 check is redundant (it’s always true inside the loop after increment). Slightly simplifies read and avoids a branch.

Apply this diff:

-        if i > 0 && decodesRealized > 0 {
+        if i > 0 {
             if i == len(encodings)-1 {
                 tempBody := request.Body()
                 *originalBody = make([]byte, len(tempBody))
                 copy(*originalBody, tempBody)
             }
             request.SetBodyRaw(body)
         }

Also applies to: 118-126

---

304-309: Avoid allocating an interim map from Header.All(): use VisitAll instead.

Header.All() typically builds an intermediate structure. VisitAll iterates without that overhead.

Apply this diff:

-    app := r.c.app
-    headers := make(map[string][]string)
-    for k, v := range r.c.fasthttp.Request.Header.All() {
-        key := app.getString(k)
-        headers[key] = append(headers[key], app.getString(v))
-    }
+    app := r.c.app
+    headers := make(map[string][]string)
+    r.c.fasthttp.Request.Header.VisitAll(func(k, v []byte) {
+        key := app.getString(k)
+        headers[key] = append(headers[key], app.getString(v))
+    })

---

346-351: Avoid panic on non-TCP transports when extracting port.

RemoteAddr() may not always be *net.TCPAddr (e.g., Unix sockets). Prefer parsing the string form safely.

Apply this diff:

-    tcpaddr, ok := r.c.fasthttp.RemoteAddr().(*net.TCPAddr)
-    if !ok {
-        panic(errors.New("failed to type-assert to *net.TCPAddr"))
-    }
-    return strconv.Itoa(tcpaddr.Port)
+    hostPort := r.c.fasthttp.RemoteAddr().String()
+    _, port, err := net.SplitHostPort(hostPort)
+    if err != nil {
+        return ""
+    }
+    return port

---

368-368: Consolidate duplicate IP header scanning logic.

extractIPsFromHeader and extractIPFromHeader implement nearly the same scanning/validation. Factor the scanner into a single helper that can return either the first valid IP or a slice to reduce maintenance and ensure consistent validation/rules.

I can draft a shared zero-allocation scanner helper used by both functions if you want to include it in this PR.

Also applies to: 411-416, 429-429, 463-470

---

541-555: Grammar nit in comment; logic is correct.

The comment under the invalid override branch has a small grammatical issue.

Apply this diff:

-    // Provided override does not valid HTTP method, no override, return current method
+    // Provided override is not a valid HTTP method; do not override; return current method

---

628-663: Prefer direct header peeks over scanning all headers in Scheme().

Iterating all headers is unnecessary overhead; check only the known proxy headers in order, trimming at the first comma. Behavior remains unchanged.

Apply this diff:

 func (r *DefaultReq) Scheme() string {
-    ctx := r.c.fasthttp
-    if ctx.IsTLS() {
-        return schemeHTTPS
-    }
-    if !r.IsProxyTrusted() {
-        return schemeHTTP
-    }
-
-    app := r.c.app
-    scheme := schemeHTTP
-    const lenXHeaderName = 12
-    for key, val := range ctx.Request.Header.All() {
-        if len(key) < lenXHeaderName {
-            continue // Neither "X-Forwarded-" nor "X-Url-Scheme"
-        }
-        switch {
-        case bytes.HasPrefix(key, []byte("X-Forwarded-")):
-            if bytes.Equal(key, []byte(HeaderXForwardedProto)) ||
-                bytes.Equal(key, []byte(HeaderXForwardedProtocol)) {
-                v := app.getString(val)
-                commaPos := strings.Index(v, ",")
-                if commaPos != -1 {
-                    scheme = v[:commaPos]
-                } else {
-                    scheme = v
-                }
-            } else if bytes.Equal(key, []byte(HeaderXForwardedSsl)) && bytes.Equal(val, []byte("on")) {
-                scheme = schemeHTTPS
-            }
-
-        case bytes.Equal(key, []byte(HeaderXUrlScheme)):
-            scheme = app.getString(val)
-        }
-    }
-    return scheme
+    ctx := r.c.fasthttp
+    if ctx.IsTLS() {
+        return schemeHTTPS
+    }
+    if !r.IsProxyTrusted() {
+        return schemeHTTP
+    }
+
+    app := r.c.app
+    h := &ctx.Request.Header
+
+    if v := app.getString(h.Peek(HeaderXForwardedProto)); v != "" {
+        if i := strings.IndexByte(v, ','); i != -1 {
+            return v[:i]
+        }
+        return v
+    }
+    if v := app.getString(h.Peek(HeaderXForwardedProtocol)); v != "" {
+        if i := strings.IndexByte(v, ','); i != -1 {
+            return v[:i]
+        }
+        return v
+    }
+    if bytes.Equal(h.Peek(HeaderXForwardedSsl), []byte("on")) {
+        return schemeHTTPS
+    }
+    if v := app.getString(h.Peek(HeaderXUrlScheme)); v != "" {
+        return v
+    }
+    return schemeHTTP
 }

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

Learnt from: gaby
PR: gofiber/fiber#3193
File: middleware/adaptor/adaptor.go:111-111
Timestamp: 2024-11-10T23:44:13.704Z
Learning: In the `middleware/adaptor/adaptor.go` file of the Fiber framework, when updating context handling, replacing `c.Context()` with `c.RequestCtx()` is appropriate to access the `fasthttp.RequestCtx`.

Learnt from: gaby
PR: gofiber/fiber#3193
File: middleware/cache/cache_test.go:897-897
Timestamp: 2024-11-08T04:10:42.990Z
Learning: In the Fiber framework, `Context()` is being renamed to `RequestCtx()`, and `UserContext()` to `Context()` to improve clarity and align with Go's context conventions.

Learnt from: gaby
PR: gofiber/fiber#3193
File: middleware/adaptor/adaptor.go:111-111
Timestamp: 2024-11-10T23:44:13.704Z
Learning: In the `middleware/adaptor/adaptor.go` file of the Fiber framework, when updating context handling, replacing `c.Context()` with `c.RequestCtx()` is appropriate to access the `fasthttp.RequestCtx`.

Learnt from: gaby
PR: gofiber/fiber#3170
File: ctx.go:1825-1826
Timestamp: 2024-10-16T14:00:50.724Z
Learning: In the Fiber framework, the `IsProxyTrusted()` function returns `true` when `TrustProxy` is `false`, maintaining compatibility with version 2 behavior.