Files that changed from the base of the PR and between e437633 and 854b918.

• go.mod is excluded by !**/*.mod

• .github/README.md (3 hunks)
• .github/workflows/benchmark.yml (1 hunks)
• .github/workflows/linter.yml (1 hunks)
• .github/workflows/test.yml (2 hunks)
• Makefile (2 hunks)
• client/client.go (1 hunks)
• client/client_test.go (1 hunks)
• client/request_test.go (2 hunks)
• ctx_test.go (3 hunks)
• docs/intro.md (1 hunks)
• docs/whats_new.md (1 hunks)
• helpers_test.go (2 hunks)
• listen.go (1 hunks)
• middleware/cache/cache_test.go (2 hunks)
• middleware/cache/manager.go (1 hunks)
• middleware/cache/manager_msgp.go (5 hunks)
• middleware/cache/manager_msgp_test.go (5 hunks)
• middleware/csrf/storage_manager.go (1 hunks)
• middleware/csrf/storage_manager_msgp.go (2 hunks)
• middleware/csrf/storage_manager_msgp_test.go (1 hunks)
• middleware/idempotency/response.go (1 hunks)
• middleware/idempotency/response_msgp.go (6 hunks)
• middleware/idempotency/response_msgp_test.go (5 hunks)
• middleware/limiter/manager.go (1 hunks)
• middleware/limiter/manager_msgp.go (1 hunks)
• middleware/limiter/manager_msgp_test.go (5 hunks)
• middleware/session/data.go (1 hunks)
• middleware/session/data_msgp.go (1 hunks)
• middleware/session/data_msgp_test.go (1 hunks)
• middleware/static/config.go (1 hunks)
• path_test.go (5 hunks)
• prefork_test.go (1 hunks)

• .github/README.md
• client/client.go
• helpers_test.go
• middleware/cache/cache_test.go
• middleware/limiter/manager.go
• middleware/session/data_msgp.go
• path_test.go

middleware/idempotency/response.go (1)

6-6: LGTM! Enhanced testing capabilities.

The addition of the -tests=true flag in the go:generate directive improves the testing capabilities of the generated code.

middleware/session/data.go (2)

7-8: LGTM! Improved code generation setup.

The go:generate directive has been updated to include tests, enhancing the testing capabilities of the generated code.

---

12-12: LGTM! Proper exclusion of sync.RWMutex.

The addition of the msg:"-" tag to sync.RWMutex ensures it is excluded from serialization, which is a best practice.

.github/workflows/linter.yml (2)

33-33: LGTM! Updated Go version.

The Go version has been updated to 1.22.x, ensuring compatibility with newer features.

---

40-40: LGTM! Updated golangci-lint version.

The golangci-lint version has been updated to v1.60.1, incorporating improvements and bug fixes.

.github/workflows/test.yml (1)

18-18: LGTM! Updates to Go versions and coverage upload conditions are appropriate.

The changes to the Go version matrix and the conditional statement for uploading coverage reports align with the PR objectives of supporting Go 1.23.

Also applies to: 34-34

middleware/csrf/storage_manager.go (2)

12-12: LGTM! Updated go:generate directive is correct.

The change from // go:generate msgp to the specific command ensures proper code generation.

---

19-21: LGTM! Struct field annotations and linter comments are appropriate.

The msg:"-" annotations correctly exclude fields from serialization, and the nolint:revive comments suppress warnings for unexported types.

Makefile (2)

38-38: LGTM! Linter version update is appropriate.

Updating to v1.60.1 ensures the latest linter features and fixes are applied.

---

60-67: LGTM! New msgp target is well-defined.

The msgp target facilitates message pack generation for multiple files, improving serialization processes.

middleware/static/config.go (1)

89-89: Verify cfg.IndexNames is never nil.

The condition now assumes cfg.IndexNames will not be nil. Ensure that the rest of the codebase guarantees this to prevent potential nil pointer dereferences.

Verification successful

---

cfg.IndexNames is never nil.

The IndexNames field in the Config struct is initialized with a default value of []string{"index.html"}, ensuring it is not nil. Additionally, there are no assignments in the codebase that set IndexNames to nil. Thus, the condition if len(cfg.IndexNames) == 0 is safe and does not risk a nil pointer dereference.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify that `cfg.IndexNames` is never `nil` before calling `configDefault`.

# Test: Search for instances where `configDefault` is called. Expect: `cfg.IndexNames` is initialized.
rg --type go -A 5 $'configDefault'

Length of output: 16218

---

Script:

#!/bin/bash
# Search for the definition of the `Config` struct to check how `IndexNames` is initialized.
ast-grep --lang go --pattern 'type Config struct { $$$ }'

Length of output: 71614

---

Script:

#!/bin/bash
# Search for assignments to `cfg.IndexNames` to ensure it is not set to `nil`.
rg --type go 'IndexNames\s*=\s*nil'

Length of output: 37

middleware/cache/manager_msgp_test.go (1)

Line range hint 12-92:
LGTM! Improved clarity and test coverage.

The renaming of functions for clarity and the addition of new test and benchmark functions enhance the code quality and functionality.

Also applies to: 94-123

middleware/limiter/manager_msgp_test.go (7)

Line range hint 12-34: Review of TestMarshalUnmarshalitem function.

The function tests the marshal and unmarshal operations for the item struct. The renaming improves clarity. The test logic is sound, ensuring no leftover bytes after unmarshalling and skipping.

---

Line range hint 35-43: Review of BenchmarkMarshalMsgitem function.

The benchmark measures the performance of the MarshalMsg method for the item struct. The renaming improves clarity. The function is correctly set up to report allocations and reset timers.

---

Line range hint 44-55: Review of BenchmarkAppendMsgitem function.

This benchmark tests the performance of appending a marshalled message. The renaming improves clarity. The setup correctly handles byte slices and reports allocations.

---

Line range hint 56-68: Review of BenchmarkUnmarshalitem function.

The benchmark evaluates the performance of the UnmarshalMsg method. The renaming improves clarity. The function correctly handles error checking and reports allocations.

---

70-92: Review of TestEncodeDecodeitem function.

The new test function enhances coverage by testing encoding and decoding operations. It checks the accuracy of Msgsize() and ensures no errors during decoding. The warning log is useful for debugging.

---

94-106: Review of BenchmarkEncodeitem function.

This new benchmark measures the performance of encoding operations. The setup is correct with buffer management and allocation reporting. The function is well-structured for performance testing.

---

108-123: Review of BenchmarkDecodeitem function.

The benchmark tests decoding performance. The setup is correct with buffer management and allocation reporting. The function is well-structured and handles errors appropriately.

middleware/idempotency/response_msgp_test.go (6)

Line range hint 35-68: Review of BenchmarkMarshalMsgresponse function.

The benchmark measures the performance of the MarshalMsg method for the response struct. The renaming improves clarity. The function is correctly set up to report allocations and reset timers.

---

Line range hint 44-55: Review of BenchmarkAppendMsgresponse function.

This benchmark tests the performance of appending a marshalled message. The renaming improves clarity. The setup correctly handles byte slices and reports allocations.

---

Line range hint 56-68: Review of BenchmarkUnmarshalresponse function.

The benchmark evaluates the performance of the UnmarshalMsg method. The renaming improves clarity. The function correctly handles error checking and reports allocations.

---

70-92: Review of TestEncodeDecoderesponse function.

The new test function enhances coverage by testing encoding and decoding operations. It checks the accuracy of Msgsize() and ensures no errors during decoding. The warning log is useful for debugging.

---

94-106: Review of BenchmarkEncoderesponse function.

This new benchmark measures the performance of encoding operations. The setup is correct with buffer management and allocation reporting. The function is well-structured for performance testing.

---

108-123: Review of BenchmarkDecoderesponse function.

The benchmark tests decoding performance. The setup is correct with buffer management and allocation reporting. The function is well-structured and handles errors appropriately.

middleware/session/data_msgp_test.go (7)

12-33: Review of TestMarshalUnmarshaldata function.

The function tests the marshal and unmarshal operations for the data struct. It ensures no leftover bytes after unmarshalling and skipping. The logic is sound and comprehensive.

---

35-42: Review of BenchmarkMarshalMsgdata function.

The benchmark measures the performance of the MarshalMsg method for the data struct. The setup is correct with allocation reporting and timer resetting.

---

44-54: Review of BenchmarkAppendMsgdata function.

This benchmark tests the performance of appending a marshalled message. The setup correctly handles byte slices and reports allocations.

---

56-68: Review of BenchmarkUnmarshaldata function.

The benchmark evaluates the performance of the UnmarshalMsg method. The function correctly handles error checking and reports allocations.

---

70-92: Review of TestEncodeDecodedata function.

The test function enhances coverage by testing encoding and decoding operations. It checks the accuracy of Msgsize() and ensures no errors during decoding. The warning log is useful for debugging.

---

94-106: Review of BenchmarkEncodedata function.

This benchmark measures the performance of encoding operations. The setup is correct with buffer management and allocation reporting. The function is well-structured for performance testing.

---

108-123: Review of BenchmarkDecodedata function.

The benchmark tests decoding performance. The setup is correct with buffer management and allocation reporting. The function is well-structured and handles errors appropriately.

middleware/cache/manager.go (1)

11-13: Enabling test generation for msgp is a positive change.

The modification to the msgp directive to generate tests will enhance the reliability and maintainability of the generated code.

middleware/limiter/manager_msgp.go (1)

9-90: The implementation of DecodeMsg and EncodeMsg enhances serialization capabilities.

The new methods for encoding and decoding item instances using MessagePack format improve the structure's functionality. The error handling is robust and provides clear context, which is beneficial for debugging.

.github/workflows/benchmark.yml (1)

34-34: Updating Go version to 1.22.x is a beneficial change.

The update to the Go version in the GitHub Actions workflow ensures that the project benefits from the latest features and improvements available in Go 1.22.x.

middleware/csrf/storage_manager_msgp.go (9)

9-35: Verify handling of map keys in DecodeMsg.

The DecodeMsg method currently defaults to skipping all keys. Ensure that this is intentional and that no fields need to be decoded.

---

38-47: LGTM!

The EncodeMsg method correctly appends a map header with size 0 for an empty struct.

---

48-53: LGTM!

The MarshalMsg method is consistent with EncodeMsg and correctly handles an empty struct.

---

Line range hint 54-92:
Verify handling of map keys in UnmarshalMsg.

The UnmarshalMsg method currently skips all keys. Ensure that this is intentional and that no fields need to be unmarshaled.

---

93-93: LGTM!

The Msgsize method correctly returns 1 for an empty struct.

---

94-120: Verify handling of map keys in DecodeMsg.

The DecodeMsg method currently skips all keys. Ensure that this is intentional and that no fields need to be decoded for storageManager.

---

123-132: LGTM!

The EncodeMsg method correctly appends a map header with size 0 for an empty struct.

---

143-171: Verify handling of map keys in UnmarshalMsg.

The UnmarshalMsg method currently skips all keys. Ensure that this is intentional and that no fields need to be unmarshaled for storageManager.

---

173-177: LGTM!

The Msgsize method correctly returns 1 for an empty struct.

docs/intro.md (1)

15-15: LGTM!

The Go version requirement update to 1.22 is consistent with the PR objectives.

middleware/csrf/storage_manager_msgp_test.go (14)

12-33: LGTM!

The TestMarshalUnmarshalitem function correctly tests the marshal and unmarshal operations for item.

---

35-42: LGTM!

The BenchmarkMarshalMsgitem function correctly benchmarks the MarshalMsg operation for item.

---

44-54: LGTM!

The BenchmarkAppendMsgitem function correctly benchmarks the append operation for item.

---

56-68: LGTM!

The BenchmarkUnmarshalitem function correctly benchmarks the UnmarshalMsg operation for item.

---

70-92: LGTM!

The TestEncodeDecodeitem function correctly tests the encode and decode operations for item.

---

94-106: LGTM!

The BenchmarkEncodeitem function correctly benchmarks the EncodeMsg operation for item.

---

108-123: LGTM!

The BenchmarkDecodeitem function correctly benchmarks the DecodeMsg operation for item.

---

125-146: LGTM!

The TestMarshalUnmarshalstorageManager function correctly tests the marshal and unmarshal operations for storageManager.

---

148-155: LGTM!

The BenchmarkMarshalMsgstorageManager function correctly benchmarks the MarshalMsg operation for storageManager.

---

157-167: LGTM!

The BenchmarkAppendMsgstorageManager function correctly benchmarks the append operation for storageManager.

---

169-181: LGTM!

The BenchmarkUnmarshalstorageManager function correctly benchmarks the UnmarshalMsg operation for storageManager.

---

183-205: LGTM!

The TestEncodeDecodestorageManager function correctly tests the encode and decode operations for storageManager.

---

207-219: LGTM!

The BenchmarkEncodestorageManager function correctly benchmarks the EncodeMsg operation for storageManager.

---

221-236: LGTM!

The BenchmarkDecodestorageManager function correctly benchmarks the DecodeMsg operation for storageManager.

middleware/idempotency/response_msgp.go (5)

9-91: Enhancements to DecodeMsg look good.

The function now correctly handles additional fields and improves error handling by wrapping errors with contextual information.

---

93-145: Enhancements to EncodeMsg look good.

The function now correctly encodes additional fields and improves error handling by wrapping errors with contextual information.

---

Line range hint 147-167:
Update to MarshalMsg aligns with new encoding structure.

The function now appends StatusCode at the end, ensuring consistency with the updated encoding structure.

---

Line range hint 169-243:
Update to UnmarshalMsg ensures complete field processing.

The function now includes the StatusCode field, ensuring all fields are decoded correctly with proper error handling.

---

Line range hint 258-269:
Update to Msgsize ensures accurate size estimation.

The function now accounts for the new encoding structure, ensuring the estimated size reflects the actual size accurately.

middleware/cache/manager_msgp.go (3)

191-202: Update to MarshalMsg aligns with encoding structure.

The function correctly marshals fields into a byte slice, consistent with the EncodeMsg structure.

---

Line range hint 204-301:
Update to UnmarshalMsg aligns with decoding structure.

The function correctly unmarshals fields from a byte slice, consistent with the DecodeMsg structure.

---

322-330: Update to Msgsize ensures accurate size estimation.

The function now accounts for the new encoding structure, ensuring the estimated size reflects the actual size accurately.

docs/whats_new.md (1)

41-41: Documentation Update Approved.

The update correctly reflects the new minimum Go version requirement for Fiber v3.

client/request_test.go (1)

1606-1607: Approved: Simplification of assertions.

The simplification of assertions in the benchmark enhances readability without altering functionality.

Files that changed from the base of the PR and between 854b918 and 8fd116d.

• .github/workflows/test.yml (2 hunks)
• middleware/limiter/limiter_fixed.go (3 hunks)
• middleware/limiter/limiter_sliding.go (2 hunks)
• middleware/limiter/limiter_test.go (2 hunks)
• prefork.go (2 hunks)

• .github/workflows/test.yml