Skip to content

Update cors.md documentation#2881

Closed
brunobmello25 wants to merge 1 commit intogofiber:mainfrom
brunobmello25:main
Closed

Update cors.md documentation#2881
brunobmello25 wants to merge 1 commit intogofiber:mainfrom
brunobmello25:main

Conversation

@brunobmello25
Copy link

Description

Recent version of golang fiber now breaks if you provide allowOrigins configuration with a space after the comma. For example, if you give the input:

https://first-url.com, https://second-url.com

it breaks with the following error:

2024/02/26 15:01:16.338384 cors.go:124: [Warn] [CORS] Invalid origin format in configuration: https://second-url.com


## Changes Introduced

- Update docs for `docs/api/middleware/cors.md`

- [x] Documentation update (changes to documentation)

@welcome
Copy link

welcome bot commented Feb 26, 2024

Thanks for opening this pull request! 🎉 Please check out our contributing guidelines. If you need help or want to chat with us, join us on Discord https://gofiber.io/discord

Copy link
Member

@sixcolors sixcolors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a bug to me.

will confirm shortly.

@sixcolors
Copy link
Member

superseeded by #2883

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants