Skip to content

Update startup message formatting#2847

Merged
ReneWerner87 merged 7 commits intogofiber:mainfrom
the-hotmann:patch-1
Feb 10, 2024
Merged

Update startup message formatting#2847
ReneWerner87 merged 7 commits intogofiber:mainfrom
the-hotmann:patch-1

Conversation

@the-hotmann
Copy link
Contributor

@the-hotmann the-hotmann commented Feb 10, 2024 •
edited
Loading

Description

BEFORE:

    _______ __             
   / ____(_) /_  ___  _____
  / /_  / / __ \/ _ \/ ___/
 / __/ / / /_/ /  __/ /    
/_/   /_/_.___/\___/_/     v3.0.0-beta.1
--------------------------------------------------
INFO Server started on http://127.0.0.1:8003 (bound on host 0.0.0.0 and port 8003)
INFO Application name: TEST APP
INFO Total handlers count: 5
INFO Prefork: Disabled
INFO PID: 2342
INFO Total process count: 1
20:49:50 | 200 |     593.769µs |   123.123.123.123 | GET     | /

AFTER:

    _______ __             
   / ____(_) /_  ___  _____
  / /_  / / __ \/ _ \/ ___/
 / __/ / / /_/ /  __/ /    
/_/   /_/_.___/\___/_/       v3.0.0-beta.1
--------------------------------------------------
INFO Server started on:      http://127.0.0.1:8003 (bound on host 0.0.0.0 and port 8003)
INFO Application name:       TEST APP
INFO Total handlers count:   5
INFO Prefork:                Disabled
INFO PID:                    2342
INFO Total process count:    1

20:49:50 | 200 |     593.769µs |   123.123.123.123 | GET     | /

Here some requested screenshots from different shalls (sh & bash & dash):

SH:
image

BASH:
image

DASH:
image

@the-hotmann
Update listen.go (unform INFO prints at startip + cosmetics)
77457f9 
BEFORE:
```
    _______ __             
   / ____(_) /_  ___  _____
  / /_  / / __ \/ _ \/ ___/
 / __/ / / /_/ /  __/ /    
/_/   /_/_.___/\___/_/     v3.0.0-beta.1
--------------------------------------------------
INFO Server started on http://127.0.0.1:8003 (bound on host 0.0.0.0 and port 8003)
INFO Application name: TEST APP
INFO Total handlers count: 5
INFO Prefork: Disabled
INFO PID: 2342
INFO Total process count: 1
20:49:50 | 200 |     593.769µs |   123.123.123.123 | GET     | / 
```

AFTER:
```
    _______ __             
   / ____(_) /_  ___  _____
  / /_  / / __ \/ _ \/ ___/
 / __/ / / /_/ /  __/ /    
/_/   /_/_.___/\___/_/     v3.0.0-beta.1
--------------------------------------------------
INFO Server started on:      http://127.0.0.1:8003 (bound on host 0.0.0.0 and port 8003)
INFO Application name:       TEST APP
INFO Total handlers count:   5
INFO Prefork:                Disabled
INFO PID:                    2342
INFO Total process count:    1

20:49:50 | 200 |     593.769µs |   123.123.123.123 | GET     | /
```
@the-hotmann
fix spacer
004bd9c
@the-hotmann
fix indentation for fiber version
f6fd827
@the-hotmann
Copy link
Contributor Author

the-hotmann commented Feb 10, 2024

Additional Screenshots with PreFork + Colorless TERM:

SH PreeFork + Colorless (Putty):
image

BASH PreeFork + Colorless (Putty):
image

DASH PreeFork + Colorless (Putty):
image

@gaby
Copy link
Member

gaby commented Feb 10, 2024

@the-hotmann The changes have to be run through https://github.com/mvdan/gofumpt the formatting is making golangci-lint to fail.

@the-hotmann
Copy link
Contributor Author

the-hotmann commented Feb 10, 2024 •
edited
Loading

Should work now.

Hmm ..
@gaby which command exatly shall I use with gofumpt?

@the-hotmann
Copy link
Contributor Author

the-hotmann commented Feb 10, 2024

Lol I just called the commit fix linting #2 which now crossreferenced an issue ..

@gaby
Copy link
Member

gaby commented Feb 10, 2024

If it fails again run this:

go install mvdan.cc/gofumpt@latest
gofumpt -l -w listen.go

@gaby
Copy link
Member

gaby commented Feb 10, 2024

If it fails again run this:

go install mvdan.cc/gofumpt@latest
gofumpt -l -w listen.go

Nvmd, it passed this time :-)

@gaby gaby requested a review from efectn February 10, 2024 20:21
@the-hotmann
Copy link
Contributor Author

the-hotmann commented Feb 10, 2024 •
edited
Loading

@gaby I already ran gofumpt -l -w listen.go, it did not change anything. The file was not modified by this command. I was using gpfumpt v0.60.

@the-hotmann the-hotmann changed the title Update listen.go (unform INFO prints at startip + cosmetics) Update listen.go (uniform INFO prints at startip + cosmetics) Feb 10, 2024
@gaby gaby changed the title Update listen.go (uniform INFO prints at startip + cosmetics) Update startup message formatting Feb 10, 2024
@ReneWerner87 ReneWerner87 merged commit 573afb9 into gofiber:main Feb 10, 2024
@welcome
Copy link

welcome bot commented Feb 10, 2024

Congrats on merging your first pull request! 🎉 We here at Fiber are proud of you! If you need help or want to chat with us, join us on Discord https://gofiber.io/discord

@the-hotmann the-hotmann deleted the patch-1 branch February 10, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gaby gaby gaby approved these changes

@ReneWerner87 ReneWerner87 ReneWerner87 approved these changes

@efectn efectn Awaiting requested review from efectn

Assignees

No one assigned

Labels

🧹 Updates v3

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@the-hotmann @gaby @ReneWerner87