Merged
Conversation
Member
gaby
commented
Feb 10, 2024
- Bump golangci-lint to v1.56.1
Member
|
hm and this |
Member
Author
|
@ReneWerner87 golangci-lint changed quite a few things in v1.56.0, I plan on fixing those. The test failing is a different issue. |
Member
And just to say it out loud, 1.56 added https://github.com/jjti/go-spancheck which has to do with opentelemetry, so we don't need it right now. |
nickajacks1
reviewed
Feb 10, 2024
Member
Author
|
This was way more changes that I thought. For some reason golangci-lint stops checking after N amount of errors. So i had to constantly be running it. Turns out there was over +100 warnings |
gaby
commented
Feb 11, 2024
efectn
approved these changes
Feb 11, 2024
nickajacks1
approved these changes
Feb 11, 2024
Member
nickajacks1
left a comment
There was a problem hiding this comment.
one small comment, thanks for fixing all of these
3 tasks
sixcolors
approved these changes
Feb 12, 2024
nickajacks1
approved these changes
Feb 12, 2024
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.