🔥 v3 (feature): Adding GetReqHeaders and GetRespHeaders#2831
Merged
ReneWerner87 merged 3 commits intogofiber:mainfrom Feb 5, 2024
Merged
🔥 v3 (feature): Adding GetReqHeaders and GetRespHeaders#2831ReneWerner87 merged 3 commits intogofiber:mainfrom
ReneWerner87 merged 3 commits intogofiber:mainfrom
Conversation
Signed-off-by: brunodmartins <bdm2943@icloud.com>
Signed-off-by: brunodmartins <bdm2943@icloud.com>
Contributor
Author
|
Not related to the PR, but I notice that some tests are randomly failling on |
Signed-off-by: brunodmartins <bdm2943@icloud.com>
3 tasks
gaby
approved these changes
Feb 5, 2024
ReneWerner87
approved these changes
Feb 5, 2024
Member
|
@efectn was there a reason why it was forgotten during the merge? can we implement this pattern better? |
Member
I suppose i removed them in favor of https://github.com/gofiber/fiber/tree/main/binder#binding-into-the-map. Anyway it will change with #2006. So the PR can be merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adding GetReqHeaders and GetRespHeaders, that had not been copied from v2 to v3
Fixes #2799
Changes Introduced
Both features and tests (unit and benchamark) were copied and adapted from v2, without major changes.
Type of Change
Please delete options that are not relevant.
Checklist
Before you submit your pull request, please make sure you meet these requirements:
/docs/directory for Fiber's documentation.Commit Formatting
Please use emojis in commit messages for an easy way to identify the purpose or intention of a commit. Check out the emoji cheatsheet here: CONTRIBUTING.md