🐛 fix(middleware/logger): default latency output format#2580
Merged
ReneWerner87 merged 4 commits intogofiber:masterfrom Aug 17, 2023
Merged
🐛 fix(middleware/logger): default latency output format#2580ReneWerner87 merged 4 commits intogofiber:masterfrom
ReneWerner87 merged 4 commits intogofiber:masterfrom
Conversation
3 tasks
ReneWerner87
approved these changes
Aug 16, 2023
Member
|
Any ideas why the CI is failing? |
Member
Author
@gaby windows VM is slow. === CONT Test_Logger_WithLatency_DefaultFormat
logger_test.go:303:
Test: Test_Logger_WithLatency_DefaultFormat
Trace: logger_test.go:303
Description: Expected latency to be in µs, got 1.5727ms
Expect: false (bool)
Result: true (bool)
=== CONT Test_Logger_WithLatency
logger_test.go:251:
Test: Test_Logger_WithLatency
Trace: logger_test.go:251
Description: Expected latency to be in µs, got 1.5727ms
Expect: false (bool)
Result: true (bool)
--- FAIL: Test_Logger_WithLatency_DefaultFormat (0.00s) |
Member
@sixcolors I wonder if removing |
Trying to make windows CI pass....
Member
Author
|
@gaby could be related to golang/go#29485 |
Member
Yeah, may need to update the tests then |
Member
|
Unrelated MacOS failure this time |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
fixes middleware/logger default latency output format to match TagLatency
Fixes #2561
Type of change
Please delete options that are not relevant.
Checklist:
Commit formatting:
Use emojis on commit messages so it provides an easy way of identifying the purpose or intention of a commit. Check out the emoji cheatsheet here: https://gitmoji.carloscuesta.me/