optimize: latency use lowest time unit in logger middleware#2261
Merged
ReneWerner87 merged 1 commit intogofiber:masterfrom Dec 10, 2022
Merged
Conversation
Contributor
Author
|
There is a datarace here and I will try to fix it. https://github.com/gofiber/fiber/actions/runs/3617013466/jobs/6095488826 |
Member
|
let me know when the pull request is mergable and you have found or fixed the datarace problem |
Contributor
Author
I haven't found the cause of this datarace yet, so I'll mention a separate PR fix😶 |
ReneWerner87
approved these changes
Dec 10, 2022
Contributor
|
Thanks mate :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Explain the details for making this change. What existing problem does the pull request solve?
Fixes #2258
Type of change
Please delete options that are not relevant.
Checklist:
Commit formatting:
Use emojis on commit messages so it provides an easy way of identifying the purpose or intention of a commit. Check out the emoji cheatsheet here: https://gitmoji.carloscuesta.me/