✨ v3: Change startup message#2041
Conversation
* Fiber figlet text is added to beginning of the startup message. Signed-off-by: Gökhan Özeloğlu <gokhan.ozeloglu@deliveryhero.com>
|
What do you think about the location of information messages? |
I think they can be under the |
Maybe they can be written like |
Both options are cool. I am going to try to implement the second option, logging one. |
* Table is removed. Logs are added. * Test cases refactored. Signed-off-by: Gökhan Özeloğlu <gokhan.ozeloglu@deliveryhero.com>
|
I didn't add color. I can use fatih/color or any other package. What do you think, @efectn? |
You can use colors like old style. I think we don't need extra dep |
* Used custom color codes to make logs colorful. * Added a new test case. * Fixed broken test case after changes. * Added some color codes as a variable. * Handled Windows case with init() function. Color codes are set empty string. Signed-off-by: Gökhan Özeloğlu <gokhan.ozeloglu@deliveryhero.com>
I added colors to log messages. You can check an example output below. What do you think? |
efectn
left a comment
There was a problem hiding this comment.
maybe we can write version right of the Fiber ASCII art
efectn
left a comment
There was a problem hiding this comment.
I think server started on message can be first or last message. Also what about adding a separator between ASCII and info messages like Echo v4.
It is like this. It can be confusing, but not a big deal. |
What do you mean by "separator between ASCII and info messages"? I don't know the Echo version. I just saw the example here. Do you mean |
No. As a text, it's very big if we do it ASCII art.
Yes |
* Color codes are taken from config. * Version is added to figlet text. * Reordered "server started on" message. * Test cases are refactored. Signed-off-by: Gökhan Özeloğlu <gokhan.ozeloglu@deliveryhero.com>
* OS checked in tests for Windows machines. Signed-off-by: Gökhan Özeloğlu <gokhan.ozeloglu@deliveryhero.com>
Signed-off-by: Gökhan Özeloğlu <gokhan.ozeloglu@deliveryhero.com>
|
@jozsefsallai what do you think about the new start message, from the code it looks good, just don't know if the design is technically good, so i'm asking someone who knows something about the subject |
|
Hi @efectn and @ReneWerner87. When do you plan to merge this PR? |
|
now |



Signed-off-by: Gökhan Özeloğlu gokhan.ozeloglu@deliveryhero.com
Description
I changed the startup message. Figlet text is added.
Fixes #2032