-
-
Notifications
You must be signed in to change notification settings - Fork 2k
Closed
Description
Feature Description
v2 definition:
type Router interface {
Use(args ...interface{}) Router
Get(path string, handlers ...Handler) Router
Head(path string, handlers ...Handler) Router
Post(path string, handlers ...Handler) Router
Put(path string, handlers ...Handler) Router
Delete(path string, handlers ...Handler) Router
Connect(path string, handlers ...Handler) Router
Options(path string, handlers ...Handler) Router
Trace(path string, handlers ...Handler) Router
Patch(path string, handlers ...Handler) Router
Add(method, path string, handlers ...Handler) Router
Static(prefix, root string, config ...Static) Router
All(path string, handlers ...Handler) Router
Group(prefix string, handlers ...Handler) Router
Route(prefix string, fn func(router Router), name ...string) Router
Mount(prefix string, fiber *App) Router
Name(name string) Router
}v3 definition:
It would be good if the signature could be changed for these:
Get(path string, handler Handler, middleware ...Handler) Router
Head(path string, handler Handler, middleware ...Handler) Router
Post(path string, handler Handler, middleware ...Handler) Router
Put(path string, handler Handler, middleware ...Handler) Router
Delete(path string, handler Handler, middleware ...Handler) Router
Connect(path string, handler Handler, middleware ...Handler) Router
Options(path string, handler Handler, middleware ...Handler) Router
Trace(path string, handler Handler, middleware ...Handler) Router
Patch(path string, handler Handler, middleware ...Handler) Router
Add(method, path string, handler Handler, middleware ...Handler) Router
All(path string, handler Handler, middleware ...Handler) Router
Secondly,
Add(methods []string, path string, handler Handler, middleware ...Handler) RouterOR alternatively,
method string interprets methods with pipes: eg. "GET|POST"
Additional Context (optional)
It will be operationally equivalent to (but cleaner):
func WithMW(handler fiber.Handler, middleware ...fiber.Handler) []fiber.Handler {
stack := make([]fiber.Handler, 0, len(middleware)+1)
stack = append(stack, middleware...)
return append(stack, handler)
}
app.Get("/hello", WithMW(func(c *fiber.Ctx) error {
return c.SendString("Hello, World 👋!")
})...)Code Snippet (optional)
No response
Checklist:
- I agree to follow Fiber's Code of Conduct.
- I have checked for existing issues that describe my suggestion prior to opening this one.
- I understand that improperly formatted feature requests may be closed without explanation.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
Type
Projects
Status
Done