Fix NDC coordinates for Vulkan in Advanced post-processing#5277
Merged
mhilbrunner merged 1 commit intoNov 3, 2021
Merged
Conversation
clayjohn
reviewed
Sep 22, 2021
clayjohn
left a comment
Member
There was a problem hiding this comment.
Line 100 needs to change as well.
243dcd9 to
8e64048
Compare
Member
Author
Fixed. I also made values explicitly floating-point, just in case. |
clayjohn
reviewed
Sep 22, 2021
Member
Author
|
Should this instance of |
8e64048 to
4ba5a42
Compare
Member
|
I don't think so. I think we still use a clip space of -1 to 1 in all three dimensions |
mhilbrunner
approved these changes
Nov 3, 2021
Member
|
Thank you! And thanks to clayjohn for reviewing :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This closes #5276.
Note: Don't cherry-pick to 3.x branches.