Expose TranslationServer::standardize_locale add_default param publicly#98972
Merged
Repiteo merged 1 commit intogodotengine:masterfrom Nov 22, 2024
Merged
Conversation
TranslationServer::standardize_locale add_default param publicly
5e13843 to
a71dad5
Compare
a71dad5 to
02a776b
Compare
Contributor
Author
|
I rebased and fixed up the conflict from #98743. |
dbnicholson
commented
Nov 12, 2024
core/string/translation_server.h
Outdated
Contributor
Author
There was a problem hiding this comment.
This should actually have been part of #98743. I can split that out to a separate PR if that's preferred.
Contributor
Author
|
@bruvzg could I get another review? Thanks! |
bruvzg
approved these changes
Nov 19, 2024
95db239 to
6930f0a
Compare
Mickeon
reviewed
Nov 19, 2024
Member
Mickeon
left a comment
There was a problem hiding this comment.
The remark about the new argument is completely fine
akien-mga
approved these changes
Nov 21, 2024
Comparing locales can have surprising outcomes since it standardizes locales with defaults. For example, zh and zh_CN result in an exact match since the defaults change them both to zh_Hans_CN. Expose the add_default parameter publicly with a default of false so the fully standardized locale can be inspected.
6930f0a to
6f4fadf
Compare
Contributor
|
Thanks! |
This comment was marked as spam.
This comment was marked as spam.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comparing locales can have surprising outcomes since it standardizes locales with defaults. For example, zh and zh_CN result in an exact match since the defaults change them both to zh_Hans_CN. Expose the add_default parameter publicly with a default of false so the fully standardized locale can be inspected.
Closes: godotengine/godot-proposals#11119