Improve lambda hotswapping when uniquely named#98221
Open
rune-scape wants to merge 3 commits intogodotengine:masterfrom
Open
Improve lambda hotswapping when uniquely named#98221rune-scape wants to merge 3 commits intogodotengine:masterfrom
rune-scape wants to merge 3 commits intogodotengine:masterfrom
Conversation
20b2dce to
fb65ad3
Compare
fb65ad3 to
9809144
Compare
9809144 to
361a1cc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR makes lambda hotswapping more stable when lambdas are named, or when a lambda is the initializer for a member, variable, or parameter
+now all script member initializer lambdas can be swapped (between
implicit_initializer,implicit_ready_info(@onreadyvars), andstatic_initializer)+added the ability to test hot-reloading scripts and added tests :3
+anonymous lambdas include the name of the variable they initialize,
<anonymous lambda(member_var)>++this formatting is up for debate but it doesn't seem like it matters that much
++it, however, may be that adding the variable name to the anonymous lambda name is undesirable, seems fine to me but i wanted to point that out
i've split this into 2 commits that add the features needed to implement this, and then the actual change
partially fixes #97834