I think this is too much complexity just to solve #96722.

The core issue in #96722 is that creating a RenderingDevice (not a local rendering device) crashes on certain hardware when a RenderingDevice has already been created. The solution is to add a check at the top of can_create_rendering_device() that checks if we are already using the Compatibility renderer. If we are, then it continues and attempts to create a RenderingDevice, if not, it does an early out and returns true.

That's fair.
Although what can_create_rendering_device() is doing is essentially the same steps as creating a local rendering device (literally the same code). I just took the opportunity to cleanup a bit and unify code

That's fair. Although what can_create_rendering_device() is doing is essentially the same steps as creating a local rendering device (literally the same code). I just took the opportunity to cleanup a bit and unify code

Not exactly. can_create_rendering_device() doesn't create a local rendering device so the flow is very different. The new function also makes the user responsible for cleaning up the RenderingDevice and Context which is a big problem for a function like this.

Also, as a bonus, while looking at the code again, I realized that it can done very simply just by checking if the RenderingDevice singleton exists:

RenderingDevice *device = RenderingDevice::get_singleton();
if (device) {
	return true;
}

This is what create_local_rendering_device() does, which is why attempting to create one works for this PR.

@Gaktan can you please rebase?
I wanted to confirm that this fixes #96938, but I am getting a non-trivial merge conflict when I cherry pick.

@dhoverml Should be good now

Thanks @Gaktan .
It looks like the crash is fixed with this PR, however, creating new windows is very slow. It takes about 1 second to create a new window (click on + Create in the Project Manager, or open any menu in the editor when Single Window Mode is false).
I don't know if that is unrelated to this PR though.

@clayjohn I'll do the simple fix for now, and do the refactor in an other PR

Thanks @Gaktan . It looks like the crash is fixed with this PR, however, creating new windows is very slow. It takes about 1 second to create a new window (click on + Create in the Project Manager, or open any menu in the editor when Single Window Mode is false). I don't know if that is unrelated to this PR though.

That's unrelated to this PR.

If you are on Windows you can improve the speed of opening new windows a lot by switching to D3D12 instead of Vulkan

@clayjohn I'll do the simple fix for now, and do the refactor in an other PR

Sounds good!

Thanks!