Skip to content

Fix FOG shader issue in Compatibility mode#94564

Merged
akien-mga merged 1 commit into
godotengine:masterfrom
rothej:fix-94183
Jul 23, 2024
Merged

Fix FOG shader issue in Compatibility mode#94564
akien-mga merged 1 commit into
godotengine:masterfrom
rothej:fix-94183

Conversation

@rothej

@rothej rothej commented Jul 20, 2024

Copy link
Copy Markdown
Contributor

Removing #ifndef DISABLE_FOG from two places to fix shader issues in Compatibility mode. Additionally, removing if (scene_data.fog_enabled) from the same, as the shader will not function properly in compatibility mode otherwise. Manually setting fog_enabled to true breaks the shader in a different way, implying that fog_enabled should not need to be true for this shader to function in compatibility mode.

@rothej rothej requested a review from a team as a code owner July 20, 2024 22:02
@akien-mga akien-mga added this to the 4.x milestone Jul 20, 2024

@Calinou Calinou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, it works as expected.

While testing, I found another bug: #94567

@akien-mga akien-mga changed the title Fixing shader issue in Compatibility mode Fix FOG shader issue in Compatibility mode Jul 21, 2024
@akien-mga akien-mga requested a review from clayjohn July 22, 2024 11:26

@clayjohn clayjohn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@clayjohn clayjohn modified the milestones: 4.x, 4.3 Jul 22, 2024
@akien-mga akien-mga added the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Jul 23, 2024
@akien-mga akien-mga merged commit 6a79d84 into godotengine:master Jul 23, 2024
@akien-mga

Copy link
Copy Markdown
Member

Thanks!

@akien-mga akien-mga removed the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Mar 19, 2025
@rothej rothej deleted the fix-94183 branch January 23, 2026 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FOG writing in shaders fails with Compatibility renderer unless enabled via WorldEnvironment

4 participants