Skip to content

Disable debug draw modes in the 3D editor according to current rendering method#93673

Merged
Repiteo merged 1 commit into
godotengine:masterfrom
Calinou:3d-editor-debug-draw-modes-mark-unsupported
Mar 12, 2025
Merged

Disable debug draw modes in the 3D editor according to current rendering method#93673
Repiteo merged 1 commit into
godotengine:masterfrom
Calinou:3d-editor-debug-draw-modes-mark-unsupported

Conversation

@Calinou

@Calinou Calinou commented Jun 27, 2024

Copy link
Copy Markdown
Member
  • Add tooltips to some debug draw modes, including when it's unsupported due to the current rendering method in use.
  • Improve documentation related to debug draw modes.

Preview

Mobile

Screenshot_20240627_200452 png webp

Compatibility

Screenshot_20240627_200422 png webp

@Calinou Calinou added this to the 4.x milestone Jun 27, 2024
@Calinou Calinou requested a review from a team June 27, 2024 18:22
@Calinou Calinou requested a review from a team as a code owner June 27, 2024 18:22
@Calinou Calinou force-pushed the 3d-editor-debug-draw-modes-mark-unsupported branch from a4824bb to 31663a1 Compare June 27, 2024 18:26

@Mickeon Mickeon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of the feedback also applies to the duplicated descriptions in Viewport.

Comment thread doc/classes/RenderingServer.xml Outdated
Comment thread doc/classes/RenderingServer.xml Outdated
Comment thread doc/classes/Viewport.xml Outdated
@Calinou Calinou force-pushed the 3d-editor-debug-draw-modes-mark-unsupported branch 2 times, most recently from 0746718 to fa46a3d Compare June 28, 2024 22:13

@Mickeon Mickeon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the class reference side of things this is fine

Comment thread editor/plugins/node_3d_editor_plugin.cpp Outdated
@akien-mga akien-mga modified the milestones: 4.x, 4.4 Aug 27, 2024
@akien-mga akien-mga requested a review from clayjohn September 4, 2024 16:36
@Repiteo Repiteo modified the milestones: 4.4, 4.x Jan 20, 2025
@Repiteo

Repiteo commented Mar 11, 2025

Copy link
Copy Markdown
Contributor

Needs a rebase before this can be merged

…ing method

- Add tooltips to some debug draw modes, including when it's unsupported
  due to the current rendering method in use.
- Improve documentation related to debug draw modes.
@Calinou Calinou force-pushed the 3d-editor-debug-draw-modes-mark-unsupported branch from fa46a3d to 5472936 Compare March 11, 2025 23:15
@Repiteo Repiteo merged commit ea892d9 into godotengine:master Mar 12, 2025
@Repiteo

Repiteo commented Mar 12, 2025

Copy link
Copy Markdown
Contributor

Thanks!

@akien-mga akien-mga modified the milestones: 4.x, 4.5 Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Vulkan Mobile backend: Some advanced debug draw modes do nothing when enabled

6 participants