Image: Add a method for detecting signed values#92799
Merged
Merged
Conversation
1 task
fire
approved these changes
Jun 5, 2024
fire
left a comment
Member
There was a problem hiding this comment.
I don't see any obvious problems so it looks good to me.
109ffe9 to
34ecaaf
Compare
Contributor
Author
|
Added a parameter for including mipmaps. |
Calinou
approved these changes
Jun 5, 2024
Calinou
left a comment
Member
There was a problem hiding this comment.
Code looks good to me. This method isn't exposed to scripting (but I don't see much need for it).
34ecaaf to
76c8211
Compare
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new
detect_signedmethod toImagefor checking whether an image has negative values. This simplifies the CVTT compression code and will be useful for #91535.