Fix crash on compatibility fallback when vkCreateRenderPass2KHR is unavailable.#91169
Merged
akien-mga merged 1 commit intoApr 26, 2024
Merged
Conversation
Merged
14 tasks
clayjohn
approved these changes
Apr 25, 2024
clayjohn
left a comment
Member
There was a problem hiding this comment.
Looks great.
This is an easy thing to validate so I trust that it works.
Member
|
No Crash ! on LG Nexus 5X, Adreno 418 |
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Originally reported here.
Resolve attachments don't get their own count attribute, but they must be ignored completely if the pointer is null. The count must match exactly color attachment count only when the pointer is not null.