Revert "Fix behavior of ResourceFormatLoader CACHE_MODE_REPLACE"#86990
Merged
Revert "Fix behavior of ResourceFormatLoader CACHE_MODE_REPLACE"#86990
CACHE_MODE_REPLACE"#86990Conversation
Member
|
This partially invalidates #82884 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CACHE_MODE_REPLACE(reverted) #84167This PR caused a regression that could lead to scene corruption, so we roll it back for now to avoid data loss for testers in our next 4.3 dev snapshot.
The changes in #84167 are still wanted and likely fix a number of reported issues, so this should be revisited, taking the time to figure out how to also solve #86187.
@SaracenOne I suggest opening a redo PR with the code from #84167, as a draft until a solution for #86187 is found.