Add shadows_disabled macro in Compatibility renderer#84416
Merged
Conversation
9b674f8 to
fb95d7d
Compare
clayjohn
approved these changes
Nov 7, 2023
clayjohn
left a comment
Member
There was a problem hiding this comment.
Seems fine to me.
Let's merge this for 4.3 as we are in the final stages of 4.2. We can cherrypick this for 4.2.1
AThousandShips
left a comment
Member
There was a problem hiding this comment.
Some accidental changes that should be restored
fb95d7d to
3867899
Compare
3867899 to
716fd3e
Compare
Calinou
requested changes
Nov 7, 2023
Calinou
left a comment
Member
There was a problem hiding this comment.
Tested locally. This PR breaks rendering in an empty project with a few meshes, even if they have no material assigned: test_pr_84416.zip
ERROR: SceneShaderGLES3: Fragment shader compilation failed:
0(1540) : error C7102: unmatched #endif
at: _display_error_with_code (drivers/gles3/shader_gles3.cpp:252)
Contributor
Author
|
Hi @Calinou Did you use the last commit, I do miss a macro there when try to fix the clang format issue. This one is broken and the latest one is fine:
|
Calinou
approved these changes
Nov 7, 2023
Contributor
Author
|
Thanks! I will try not to update my llvm too aggressively next time :( |
shadows_disabled macro in Compatibility renderer
Member
|
Thanks! |
Contributor
|
Cherry-picked for 4.2.1. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #84386