Fix OpenGL directional shadow last split fading#83252
Merged
Merged
Conversation
d7e21ba to
7f6a93b
Compare
jsjtxietian
reviewed
Oct 13, 2023
7f6a93b to
09a2a7c
Compare
Contributor
Author
|
Squashed |
clayjohn
approved these changes
Oct 13, 2023
clayjohn
left a comment
Member
There was a problem hiding this comment.
Yep, let's nuke it. This was an accidental copy-paste from the GLES2 code in Godot 3.x
Calinou
approved these changes
Oct 13, 2023
Calinou
left a comment
Member
There was a problem hiding this comment.
Tested locally, it works as expected.
Member
|
Thanks! And congrats for your first merged Godot contribution 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #82505
I have no ideas what pssm fade was ment to do, however based on the shader code my guess is that it was an attempt to apply the fading controlled by fade start that got scrapped halfway through the implementation and replaced with a proper implementation, given that I cannot see anything of the sort in the Vulkan Renderer to indicate some other specific feature.