Remove redundant/unused SSAO property ao_channel_affect#82274
Open
briansemrau wants to merge 1 commit into
Open
Remove redundant/unused SSAO property ao_channel_affect#82274briansemrau wants to merge 1 commit into
briansemrau wants to merge 1 commit into
Conversation
c5fabb5 to
4b7335e
Compare
Member
|
You need to handle the compatibility breakages, adding compatibility methods, for examples look at |
Member
Let's see first if the rendering team agrees with the removal and compat breakage before adding compatibility code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #54611
I found that the default value for for ao channel effect of 0 was causing SSAO to not work in my scenes. This property was performing the same role as ssao intensity. (This might be what this comment was referring to, accidentally swapping terms?) (Related to #43957)