[3.x] CPUParticles2D - Add ability to follow physics interpolated target#80931
Merged
akien-mga merged 2 commits intogodotengine:3.xfrom Sep 18, 2023
Merged
[3.x] CPUParticles2D - Add ability to follow physics interpolated target#80931akien-mga merged 2 commits intogodotengine:3.xfrom
CPUParticles2D - Add ability to follow physics interpolated target#80931akien-mga merged 2 commits intogodotengine:3.xfrom
Conversation
CPUParticles2D - Add ability to follow physics interpolated targetCPUParticles2D - Add ability to follow physics interpolated target
Calinou
approved these changes
Aug 23, 2023
Member
There was a problem hiding this comment.
Tested locally in https://github.com/Calinou/platshoot/tree/physics-interpolation-test, it works as expected (as long as interpolation is disabled on the CPUParticles2D, which is the case by default). The player's jetpack particles are now smoothed out with no jittering when the player moves 🙂
b3237c7 to
1075f17
Compare
Changes the implementation of non-interpolated global mode particles so that the vertices are specified in proper global space instead of local space (vertices were previously back transformed by the inverse of the parent transform).
Allows a non-interpolated particle system to closely follow an interpolated target without tracking ahead of the target, by performing fixed timestep interpolation on the particle system global transform, and using this for emission.
1075f17 to
3e19cf8
Compare
akien-mga
approved these changes
Sep 18, 2023
Member
|
Thanks! |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows a non-interpolated particle system to closely follow an interpolated target without tracking ahead of the target, by performing fixed timestep interpolation on the particle system global transform, and using this for emission.
Changes the default physics interpolation mode of
CPUParticles2Dto OFF, as in most cases this looks much better and mimics the behaviour of particles simulating every frame when physics interpolation is not in use.Witness particles now look excellent even at low physics tick rates, here it is 3 physics ticks per second! 😮
2023-08-23.17-26-28.mp4
Notes
NOTIFICATION_TRANSFORM#80827 . These should be reviewed / merged first then this PR can be rebased.global_transform, in order to decide where to emit particles between physics ticks. This includes the machinery forreset_physics_interpolation().