Overhaul OS documentation#80282
Conversation
3c1a294 to
0bb45dd
Compare
0bb45dd to
1f1ec8e
Compare
If enabled when opening a file for writing, a temporary file is used first, and only when it's closed it is renamed or used to replace an existing file. This is useful in case the original file is opened by other app, scanned by antivirus for example. |
1f1ec8e to
44dafad
Compare
|
Pushed a commit that also attempts to address the above comments. I hope you check again. |
a4f4766 to
8435e70
Compare
|
How did the latest unit test even fail? |
Unit tests didn't fail, but there is a problem with thread sanitizer runs. It's not related to your PR and seems to happen sporadically, a re-run fixed it. |
8435e70 to
a9d3fc5
Compare
|
Rebased after #81416 |
a9d3fc5 to
76d5f8e
Compare
|
Pushed changes that accept the C# suggestions above. Thank you @raulsntos for the additional attention to this PR. |
76d5f8e to
26a2fa0
Compare
26a2fa0 to
2015b68
Compare
2015b68 to
bb46dea
Compare
|
Rebased after:
Would be nice for this to be taken a look at sooner than later |
AThousandShips
left a comment
There was a problem hiding this comment.
Some minor changes, style looks good otherwise, can't speak for the factual correctness however so someone else needs to verify
bb46dea to
a6b9c49
Compare
|
Addressed the above feedback. Thank you. I also moved the mention of |
akien-mga
left a comment
There was a problem hiding this comment.
Only skimmed through the changes, looks good overall.
67adb05 to
c7931d5
Compare
c7931d5 to
36da3f1
Compare
|
Reverted that comma, but also updated the |
36da3f1 to
465e843
Compare
|
Thanks! |
Draft because more could be done soon. I would love your assistance!Continuation of similar past efforts with the same goal of refreshing the documentation up a notch.
This is particularly prickly due of the sheer size. There's also a constant fear of possibly losing important information, or making use of incorrect technical terms. A lot of the time is spent reading the original documentation and looking at the source code, too. Fortunately, a decent majority of it is written... quite up to date, too.
will return->returns);close_midi_inputs,get_connected_midi_inputs,open_midi_inputsget_cmdline_user_argsget_keycode_string,find_keycode_from_stringrequest_permission,revoke_granted_permissionsget_user_data_dirProjectSettings.application/config/use_custom_user_dirdirectly.Feedback is very, very welcome, even in the draft state. And especially right now. This class is huge and very technical.
In fact, I would like to propose a few questions that may help with this cause:
OS.move_to_trash()really implemented only on Android, Linux, macOS and Windows?OS.request_permissionandOS.request_permissionreturntruewhen permissions are granted successfully?What doesOS.set_use_file_access_save_and_swapreally do?