Remove unused variable PopupMenu::parent_rect#78268
Merged
akien-mga merged 1 commit intogodotengine:masterfrom Jun 15, 2023
Merged
Remove unused variable PopupMenu::parent_rect#78268akien-mga merged 1 commit intogodotengine:masterfrom
PopupMenu::parent_rect#78268akien-mga merged 1 commit intogodotengine:masterfrom
Conversation
Member
|
Added breaks compat as it's part of the public API on the c++ side |
fe26d42 to
cd0bda2
Compare
Contributor
Author
|
I have updated the PR to be no longer compatibility breaking. Please remove the label. |
Member
|
I think it's fine to remove it, we don't guarantee compatibility for the public C++ API which isn't exposed to scripting and GDExtension (at least between minor versions). |
This private variable is not read anywhere. Remove it and all places, where it is set.
cd0bda2 to
840e2b1
Compare
Contributor
Author
|
Sounds good, I have removed the function again. |
akien-mga
approved these changes
Jun 15, 2023
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This private variable is not read anywhere.
Remove it and all places, where it is set.