Skip to content

Document MIDI zero velocity quirk more completely#77103

Merged
mhilbrunner merged 1 commit intogodotengine:masterfrom
voidshine:doc_midi_note_velocity_quirk
May 18, 2023
Merged

Document MIDI zero velocity quirk more completely#77103
mhilbrunner merged 1 commit intogodotengine:masterfrom
voidshine:doc_midi_note_velocity_quirk

Conversation

@voidshine
Copy link
Copy Markdown
Contributor

@voidshine voidshine commented May 15, 2023 •
edited by akien-mga
Loading

@voidshine voidshine requested a review from a team as a code owner May 15, 2023 16:04
@voidshine
Copy link
Copy Markdown
Contributor Author

voidshine commented May 15, 2023

@akien-mga recommended expanding the documentation, and this PR does just that.

#76678 (comment)

@YuriSizov YuriSizov added this to the 4.x milestone May 15, 2023
akien-mga
akien-mga reviewed May 15, 2023
View reviewed changes
akien-mga
akien-mga reviewed May 15, 2023
View reviewed changes
@akien-mga akien-mga modified the milestones: 4.x, 4.1 May 15, 2023
@voidshine
Copy link
Copy Markdown
Contributor Author

voidshine commented May 16, 2023

Thanks for the improvements! Both suggestions are committed.

@akien-mga
Copy link
Copy Markdown
Member

akien-mga commented May 16, 2023

Looks good! Could you squash the commits? See PR workflow for instructions.

@voidshine voidshine force-pushed the doc_midi_note_velocity_quirk branch from 1412eef to 6174228 Compare May 16, 2023 17:17
@voidshine
Copy link
Copy Markdown
Contributor Author

voidshine commented May 16, 2023

Squashed & force pushed, thanks for the reminder. :)

@akien-mga
Copy link
Copy Markdown
Member

akien-mga commented May 17, 2023

Needs another rebase to fix an unrelated CI issue (temporary mismatch between this repo and the godot-cpp one used in a test at the time you last rebased).

@voidshine voidshine force-pushed the doc_midi_note_velocity_quirk branch from a979d25 to 6174228 Compare May 17, 2023 18:32
@voidshine voidshine force-pushed the doc_midi_note_velocity_quirk branch from ec29c67 to 06d0292 Compare May 17, 2023 19:22
@voidshine
Copy link
Copy Markdown
Contributor Author

voidshine commented May 17, 2023

Okay, synced and rebased.

@mhilbrunner mhilbrunner merged commit b40b35f into godotengine:master May 18, 2023
@mhilbrunner
Copy link
Copy Markdown
Member

mhilbrunner commented May 18, 2023

Thanks and congrats on your first merged Godot PR! 🎉

@YuriSizov
Copy link
Copy Markdown
Contributor

YuriSizov commented May 18, 2023

Cherry-picked for 4.0.3.

@Mickeon Mickeon mentioned this pull request Jan 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mhilbrunner mhilbrunner mhilbrunner approved these changes

@akien-mga akien-mga akien-mga approved these changes

Assignees

No one assigned

Labels

documentation enhancement topic:audio

Projects

None yet

Milestone

4.1

Development

Successfully merging this pull request may close these issues.

4.0, MIDI input: releasing key on MIDI device returns event.message 0x9 (MIDI_MESSAGE_NOTE_ON); should be 0x8 (MIDI_MESSAGE_NOTE_OFF)

4 participants

@voidshine @akien-mga @mhilbrunner @YuriSizov