Draw frustum splices on top of direction shadow atlas for debug purposes#77085
Merged
YuriSizov merged 1 commit intoJul 12, 2023
Merged
Conversation
5e891bc to
2b23361
Compare
2b23361 to
2bda4e7
Compare
Contributor
Author
Member
This should be mentioned in the class reference 🙂 |
2bda4e7 to
63e72be
Compare
Contributor
Author
@Calinou added a description, let me know if this is clear enough |
63e72be to
a952eb8
Compare
Contributor
Author
8a7ed7e to
dc78f27
Compare
Contributor
Author
dc78f27 to
b92fa3c
Compare
clayjohn
reviewed
May 26, 2023
clayjohn
left a comment
Member
There was a problem hiding this comment.
Just some nitpicky formatting comments, otherwise this looks good to go
b92fa3c to
c6a2f08
Compare
Calinou
reviewed
May 29, 2023
c6a2f08 to
85ca16b
Compare
Contributor
Author
85ca16b to
861e132
Compare
861e132 to
d9eb966
Compare
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.







To help debug issues with directional shadows this PR introduces a mechanism of drawing the view frustum splices into the directional atlas when displayed in the interface:
This will help with setting up better splits and to see if we're effectively culling out objects that do not need to be drawn into the shadow map.