Use proper UV in cubemap downsampler raster (Fixes reflections in mobile renderer)#76692
Merged
Merged
Conversation
This removes bias in cubemap downsampling shader that resulted in the bottom of cubemaps being over represented
Calinou
approved these changes
May 3, 2023
Calinou
left a comment
Member
There was a problem hiding this comment.
I never thought this would be the cause of the issue, but good catch 🙂
mhilbrunner
approved these changes
May 3, 2023
Member
|
Thanks! ❤️ |
Member
|
Cherry-picked for 4.0.3. |
|
If I understand this correctly this will mean that scenes using environment lighting on the Mobile renderer will get brighter with this change (since the old darker lighting was a bug) and environments will need to be adjusted to get the 4.0.x appearance? If so, perhaps it would be good to describe and warn about this in the change notes when 4.1 is released, as it might be unexpected for people working on projects using the Mobile renderer as the base rather than Forward + to have the light levels change in all their scenes without understanding why. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #55878
This removes bias in cubemap downsampling shader that resulted in the bottom of cubemaps being over represented
Hint: review with whitespace hidden as most of the changes here are whitespace related
Before:
After:
Forward+
