Implement cull_mask for decals and lights in mobile and compatibility backends#72810
Merged
Conversation
akien-mga
approved these changes
Feb 6, 2023
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #65848
cull_maskworks in the clustered renderer because it is checked in the fragment shader at draw time. But for the other renderers, it was being ignored completely.The Mobile and gl_compatibility renderers "pair" decals and lights with GeometryInstances. The pairing happens in RendererSceneCull when either of the objects are updated. Previously, the pairing logic only checked if the objects overlapped and if they were the type of objects that can pair (i.e. a light can't pair with a decal, but it can pair with a GeometryInstance). The pairing logic needs to avoid pairing objects with incompatible cull masks. And it needs to update when the cull_mask is changed.
This PR just adds the cull_mask to the pair culling logic