Fix GDScriptCache to not remove scripts/scenes individually when clearing#69865
Merged
akien-mga merged 1 commit intogodotengine:masterfrom Dec 10, 2022
Merged
Conversation
This was referenced Dec 10, 2022
akien-mga
approved these changes
Dec 10, 2022
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split PR from #69587 for everything about
GDScriptCache.Should prevent
GDScript::~GDScript()instances to callGDScriptCache::remove_script()when theGDScriptwas destructed becauseGDScriptCache::clear()erased the hashmap. Otherwise,GDScriptCache::remove_script()will callerase()on the hashmap, causing a crash or aheap-use-after-freeerror.Fixes #69183 (Crash on exit in the GDScript module when debugging Godot) (hopefully)