Skip to content

[MSVC] Use symbols from .pdb only, to avoid incorrect names in the backtrace when symbols are missing.#69332

Merged
akien-mga merged 1 commit intogodotengine:masterfrom
bruvzg:exact_symbols
Nov 29, 2022
Merged

[MSVC] Use symbols from .pdb only, to avoid incorrect names in the backtrace when symbols are missing.#69332
akien-mga merged 1 commit intogodotengine:masterfrom
bruvzg:exact_symbols

Conversation

@bruvzg
Copy link
Copy Markdown
Member

@bruvzg bruvzg commented Nov 29, 2022

Fixes #69295

@akien-mga akien-mga merged commit 82e4582 into godotengine:master Nov 29, 2022
@akien-mga
Copy link
Copy Markdown
Member

Thanks!

@akien-mga akien-mga added cherrypick:3.x Considered for cherry-picking into a future 3.x release cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release labels Nov 29, 2022
@bruvzg bruvzg deleted the exact_symbols branch November 29, 2022 16:44
@timothyqiu
Copy link
Copy Markdown
Member

Cherry-picked for 3.6

@timothyqiu timothyqiu removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Dec 12, 2022
@timothyqiu
Copy link
Copy Markdown
Member

Cherry-picked for 3.5.2

@timothyqiu timothyqiu removed the cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release label Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MSVC crash stacktrace without debug symbols wrongly points to embree and oidn symbols

3 participants