Skip to content

Remove fix leftover that caused cyclic load issues#68872

Merged
Chaosus merged 1 commit intogodotengine:masterfrom
adamscott:remove-fix-leftover
Nov 19, 2022
Merged

Remove fix leftover that caused cyclic load issues#68872
Chaosus merged 1 commit intogodotengine:masterfrom
adamscott:remove-fix-leftover

Conversation

@adamscott
Copy link
Copy Markdown
Member

@adamscott adamscott commented Nov 19, 2022 •
edited by akien-mga
Loading

This PR removes an attempt that was leftover in the #67714 PR which was merged a few hours ago.

The code removed was causing issues like this one:

Loading resource: res://Nodes/Technical/Jukebox.tscn
ERROR: Another resource is loaded from path 'res://Nodes/Technical/Jukebox.tscn::1' (possible cyclic resource inclusion).
   at: set_path (core/io/resource.cpp:75)
ERROR: Another resource is loaded from path 'res://Nodes/Technical/Jukebox.tscn::2' (possible cyclic resource inclusion).
   at: set_path (core/io/resource.cpp:75)
ERROR: Another resource is loaded from path 'res://Nodes/Technical/Jukebox.tscn::3' (possible cyclic resource inclusion).
   at: set_path (core/io/resource.cpp:75)
ERROR: Another resource is loaded from path 'res://Nodes/Technical/Jukebox.tscn::4' (possible cyclic resource inclusion).
   at: set_path (core/io/resource.cpp:75)
ERROR: Another resource is loaded from path 'res://Nodes/Technical/Jukebox.tscn::5' (possible cyclic resource inclusion).
   at: set_path (core/io/resource.cpp:75)
ERROR: Another resource is loaded from path 'res://Nodes/Technical/Jukebox.tscn::6' (possible cyclic resource inclusion).
   at: set_path (core/io/resource.cpp:75)
ERROR: Another resource is loaded from path 'res://Nodes/Technical/Jukebox.tscn::AnimationLibrary_3jtqj' (possible cyclic resource inclusion).
   at: set_path (core/io/resource.cpp:75)

It was an attempt to fix- #61386.

@adamscott adamscott requested a review from a team as a code owner November 19, 2022 04:42
@Chaosus Chaosus added this to the 4.0 milestone Nov 19, 2022
@Chaosus Chaosus merged commit c2f0353 into godotengine:master Nov 19, 2022
@Chaosus
Copy link
Copy Markdown
Member

Chaosus commented Nov 19, 2022

Thanks!

@adamscott adamscott mentioned this pull request Nov 19, 2022
Closed
@souplamp souplamp mentioned this pull request Nov 22, 2022
Closed
@adamscott adamscott mentioned this pull request Nov 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Chaosus Chaosus Chaosus approved these changes

Assignees

No one assigned

Labels

bug topic:gdscript

Projects

None yet

Milestone

4.0

Development

Successfully merging this pull request may close these issues.

2 participants

@adamscott @Chaosus