Skip to content

Fix position and size of OptionButton PopupMenu#68573

Merged
akien-mga merged 1 commit intogodotengine:masterfrom
Sauermann:fix-optionbutton-popup
Nov 16, 2022
Merged

Fix position and size of OptionButton PopupMenu#68573
akien-mga merged 1 commit intogodotengine:masterfrom
Sauermann:fix-optionbutton-popup

Conversation

@Sauermann
Copy link
Contributor

@Sauermann Sauermann commented Nov 12, 2022

Use the correct Transform2D (get_global_transform_with_canvas) for position and size, which need to be in Viewport- coordinates.
resolve #68554

@Sauermann Sauermann requested a review from a team as a code owner November 12, 2022 18:53
@Sauermann Sauermann force-pushed the fix-optionbutton-popup branch 2 times, most recently from fc9845b to 634925a Compare November 12, 2022 19:15
Use the correct Transform2D (get_global_transform_with_canvas) for
position and size.
@Sauermann Sauermann force-pushed the fix-optionbutton-popup branch from 634925a to 95597bb Compare November 12, 2022 20:12
@Chaosus Chaosus added this to the 4.0 milestone Nov 13, 2022
@akien-mga akien-mga merged commit 2846ea1 into godotengine:master Nov 16, 2022
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PopupMenu from OptionButton placed at wrong position and with wrong size when Camera2D has Zoom value other than (1,1)

4 participants