You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Supercedes: #55758 and partially supercedes #55757 (this does not affect normal bias)
This PR increases the amount of bias used proportional to the radius of the PCF shadow filter. When using a larger filter radius, we need to use a greater bias. This reduces the shadow acne visible for all quality settings (because soft_shadow_scale is greater than 1 for all quality settings above hard shadows.
The unfortunate side effect of this change is an increase in peter-panning at high quality levels, but that is a necessary consequence to avoid shadow acne. I.e. without this PR if you tweak shadow_bias to the point of removing shadow acne you get about the same amount of peter-panning.
The unfortunate side effect of this change is an increase in peter-panning at high quality levels, but that is a necessary consequence to avoid shadow acne.
#55757 might help here, if we also decrease the default DirectionalLight3D shadow bias in exchange (but keep the doubled shadow normal bias from that PR).
The unfortunate side effect of this change is an increase in peter-panning at high quality levels, but that is a necessary consequence to avoid shadow acne.
#55757 might help here, if we also decrease the default DirectionalLight3D shadow bias in exchange (but keep the doubled shadow normal bias from that PR).
It is definitely worth looking into. I tried out a few variations of increased normal/decrease bias and wasn't able to reduce peter-panning much, but I think a closer look would be valuable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #54523
Supercedes: #55758 and partially supercedes #55757 (this does not affect normal bias)
This PR increases the amount of bias used proportional to the radius of the PCF shadow filter. When using a larger filter radius, we need to use a greater bias. This reduces the shadow acne visible for all quality settings (because
soft_shadow_scaleis greater than 1 for all quality settings abovehard shadows.The unfortunate side effect of this change is an increase in peter-panning at high quality levels, but that is a necessary consequence to avoid shadow acne. I.e. without this PR if you tweak
shadow_biasto the point of removing shadow acne you get about the same amount of peter-panning.Before: Low Quality (default)
After: Low Quality
Before: Ultra Quality
After: Ultra Quality
