Allow clearing backbuffer after finishing CanvasGroup#67051
Merged
Conversation
This avoids an issue where having multiple CanvasGroups overlap would create a weird artifact
akien-mga
approved these changes
Oct 7, 2022
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #60301 (comment)
Previously we would mark the backbuffer as having been cleared once it was cleared so we wouldn't have to clear it multiple times. But we need to clear it multiple times if we are going to reuse it for a subsequent CanvasGroup.
This PR fixes the bug by resetting the
backbuffer_clearedbool once a CanvasGroup has finished drawing flagging that the backbuffer can be cleared again if needed.Before:
After: