SCons: Cleanup DEBUG, _DEBUG and NDEBUG defines#66303
Merged
akien-mga merged 1 commit intoSep 23, 2022
Merged
Conversation
- `_DEBUG` is MSVC specific so it didn't make much sense to define for Android and iOS builds. - iOS was the only platform to define `DEBUG`. We don't use it anywhere outside thirdparty code, which we usually don't intend to debug, so it seems better to be consistent with other platforms. - Consistently define `NDEBUG` to disable assert behavior in both `release` and `release_debug` targets. This used to be set for `release` for all platforms, and `release_debug` for Android and iOS only. - Due to the above, I removed the only use we made of `assert()` in Godot code, which was only implemented for Unix anyway, should have been `DEV_ENABLED`, and is in PoolAllocator which we don't actually use. - The denoise and recast modules keep defining `NDEBUG` even for the `debug` target as we don't want OIDN and Embree asserting all over the place.
JFonS
approved these changes
Sep 23, 2022
JFonS
left a comment
Contributor
There was a problem hiding this comment.
Changes in Embree and OIDN look good.
Member
Author
|
Cherry-picked for 3.6. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_DEBUGis MSVC specific so it didn't make much sense to define for Android and iOS builds.DEBUG. We don't use it anywhere outside thirdparty code, which we usually don't intend to debug, so it seems better to be consistent with other platforms.NDEBUGto disable assert behavior in bothreleaseandrelease_debugtargets. This used to be set forreleasefor all platforms, andrelease_debugfor Android and iOS only.assert()in Godot code, which was only implemented for Unix anyway, should have beenDEV_ENABLED, and is in PoolAllocator which we don't actually use.NDEBUGeven for thedebugtarget as we don't want OIDN and Embree asserting all over the place.