Skip to content

Fix LinearDepth calculation in the Visual Shader node for GLES3#65160

Merged
Chaosus merged 1 commit into
godotengine:masterfrom
paddy-exe:fix-linear-depth-gles
Aug 31, 2022
Merged

Fix LinearDepth calculation in the Visual Shader node for GLES3#65160
Chaosus merged 1 commit into
godotengine:masterfrom
paddy-exe:fix-linear-depth-gles

Conversation

@paddy-exe

@paddy-exe paddy-exe commented Aug 31, 2022

Copy link
Copy Markdown
Contributor

This change will calculate the depth ndc differently for GLES3 and Vulkan as described in here:
stable:
https://docs.godotengine.org/en/stable/tutorials/shaders/advanced_postprocessing.html
godot 4 with vulkan:
https://docs.godotengine.org/en/latest/tutorials/shaders/advanced_postprocessing.html

Original PR: #64248

@paddy-exe paddy-exe requested a review from a team as a code owner August 31, 2022 19:01

@clayjohn clayjohn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@Chaosus Chaosus merged commit a5db03e into godotengine:master Aug 31, 2022
@Chaosus

Chaosus commented Aug 31, 2022

Copy link
Copy Markdown
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants