Skip to content

Rename SoftDynamicBody3D to SoftBody3D#64548

Closed
Mickeon wants to merge 1 commit into
godotengine:masterfrom
Mickeon:rename-soft-body
Closed

Rename SoftDynamicBody3D to SoftBody3D#64548
Mickeon wants to merge 1 commit into
godotengine:masterfrom
Mickeon:rename-soft-body

Conversation

@Mickeon

@Mickeon Mickeon commented Aug 17, 2022

Copy link
Copy Markdown
Member

After godotengine/godot-proposals#5183, an argument can be made that the current name for SoftDynamicBody is also counterproductive to what the new Node naming scheme for Godot 4 aims to achieve. It's misleading, and the longer name doesn't add much meaning, but it typically gets a pass because it's not nearly as common as Rigid Bodies in game engines.

So "SoftDynamicBody" is not a physics body apparently, but I was misled thinking it was... Adds to the reasons I don't like the name. Really hoping a rename of RigidDynamicBody makes it into 4.0 so we don't just have to live with it

The name soft body has also been used to describe deformable objects in physics simulations longer than Godot has existed. I do not see a reason why this was changed.

SoftDynamicBody3D -> SoftBody3D
SoftDynamicBody3DGizmoPlugin -> SoftBody3DGizmoPlugin (this class is not exposed)

image

Affects the file names, as well.

Bugsquad edit: See also #64546 for RigidBody.

SoftDynamicBody3D -> SoftBody3D
SoftDynamicBody3DGizmoPlugin -> SoftBody3DGizmoPlugin (this class is not exposed)

Affects the file names, as well.
@Mickeon Mickeon requested a review from a team as a code owner August 17, 2022 20:44
@Mickeon Mickeon requested a review from a team August 17, 2022 20:44
@Mickeon Mickeon requested review from a team as code owners August 17, 2022 20:44
@Calinou Calinou added this to the 4.0 milestone Aug 17, 2022
@YuriSizov

Copy link
Copy Markdown
Contributor

Agreed to the rename in the bikeshedding meeting.

@YuriSizov

Copy link
Copy Markdown
Contributor

Superseded by #64894. Thanks for contributing nonetheless!

@YuriSizov YuriSizov closed this Aug 25, 2022
@Mickeon Mickeon deleted the rename-soft-body branch February 27, 2024 11:45
@AThousandShips AThousandShips removed this from the 4.0 milestone Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Status: Approved

Development

Successfully merging this pull request may close these issues.

4 participants