Skip to content

Fixes some 'Attempted to free invalid ID' warnings in mobile renderer#57904

Merged
akien-mga merged 1 commit into
godotengine:masterfrom
V-Sekai:fix_double_free_warning
Feb 15, 2022
Merged

Fixes some 'Attempted to free invalid ID' warnings in mobile renderer#57904
akien-mga merged 1 commit into
godotengine:masterfrom
V-Sekai:fix_double_free_warning

Conversation

@SaracenOne

@SaracenOne SaracenOne commented Feb 10, 2022

Copy link
Copy Markdown
Member

Fix _free_render_buffer_data freeing half_texture and half_fb the mipmap array of both blur structs when switching scenes. During assignment, half_texture and half_fb in each of the mipmaps of both arrays are assigned the same texture and framebuffer, and since _free_render_buffer_data attempts to free both, the engine throws up a warning since they have already been erased in the first blur struct.

Fixes #51752

@clayjohn clayjohn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@akien-mga akien-mga merged commit af91a42 into godotengine:master Feb 15, 2022
@akien-mga

Copy link
Copy Markdown
Member

Thanks!

@fire fire deleted the fix_double_free_warning branch September 16, 2022 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Attempted to free invalid ID errors when closing project with mobile renderer

3 participants