Document InputEventMIDI and add some missing 0xF MIDI messages#56295
Merged
akien-mga merged 1 commit intogodotengine:masterfrom Jan 4, 2022
Merged
Document InputEventMIDI and add some missing 0xF MIDI messages#56295akien-mga merged 1 commit intogodotengine:masterfrom
akien-mga merged 1 commit intogodotengine:masterfrom
Conversation
239df7c to
9636a94
Compare
mhilbrunner
approved these changes
Dec 31, 2021
mhilbrunner
approved these changes
Jan 4, 2022
Member
mhilbrunner
left a comment
There was a problem hiding this comment.
Approved in PR meeting, 2 more missing constants need to be amended with a note that their associated data can't be retrieved/used currently
akien-mga
approved these changes
Jan 4, 2022
Member
akien-mga
left a comment
There was a problem hiding this comment.
Looks good to me, if we can receive these messages it makes sense to have constants (and docs!) for them. As discussed in PR meeting, apparently there's two more that we can receive but not handle well, it could still make sense to expose them and document the fact that we don't support them.
akien-mga
approved these changes
Jan 4, 2022
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR documents the InputEventMIDI class. Fixes godotengine/godot-docs#3992
The documentation is based on a combination of my research online and with testing on a Yamaha MX88 piano. I also created this demo for an example of how to use MIDI in Godot: godotengine/godot-demo-projects#674
This PR also adds some missing enum members for some of the possible MIDI messages.