Remove build system code for 32-bit iOS#55793
Merged
Merged
Conversation
akien-mga
reviewed
Dec 10, 2021
Member
There was a problem hiding this comment.
Might be worth reviewing why we define this only for x86_64.
akien-mga
reviewed
Dec 10, 2021
Comment on lines
108
to
109
Member
There was a problem hiding this comment.
Now that there's only two arches, I guess there would be an option to split the shared CCFLAGS outside the if check, and then just do arch-based appends for the flags which are unique for each platform (and ideally we should document why we use those flags for each). (Not necessarily in this PR.)
Member
|
Looks good to me if we're OK with removing this support. |
akien-mga
approved these changes
Dec 22, 2021
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
32-bit iOS does not exist anymore, and support for 32-bit apps was removed in 2017.
x86_64 iOS still exists in simulators, and the only architecture that exists on real iPhones is now arm64.