Misc build system fixes#55792
Conversation
I'd be more in favor of making Windows consistent with macOS/Linux, which are the platforms where the sanitizers are used most. On Windows only address sanitizer is implemented and only for MSVC. This minimizes the compat breakage and makes this PR suitable for a Alternatively, if we really want to use a Either way, this PR doesn't seem to update the CI workflow so I guess it might fail. |
|
Sanitization isn't related to architecture, so it would make more sense to me to have |
There was a problem hiding this comment.
That's changing behavior here. ERR_CONTINUE_MSG prints an error, then continue.
There was a problem hiding this comment.
Should we have ERR_CONTINUE_MSG(true, "Light type is unknown."); or ERR_PRINT("Light type is unknown."); continue;?
There was a problem hiding this comment.
It's equivalent, I guess we can go with ERR_CONTINUE_MSG(true, ...) to make the intention explicit.
Alternatively it would be:
} else {
ERR_CONTINUE_MSG(type != "point" && type != "directional", "Light type is unknown.");
}
While at it, could be useful to print type in the error for debugging purposes.
There was a problem hiding this comment.
Reviewed. ERR_CONTINUE_MSG(true, ...) and adding types makes sense.
|
Thanks! |
.sand macOS/Linux hads, now they're all.san.ifin Android that should beelif.