[3.x] Remove redundant thread sync counter draw_pending#47232
Merged
akien-mga merged 1 commit intogodotengine:3.xfrom Aug 6, 2022
Merged
[3.x] Remove redundant thread sync counter draw_pending#47232akien-mga merged 1 commit intogodotengine:3.xfrom
akien-mga merged 1 commit intogodotengine:3.xfrom
Conversation
Contributor
Author
|
Provided for convenience. If only one PR can be merged, pick #35718. It's just a tiny bug affecting unrealistic projects in a manner that would probably not even be observable to players. |
|
Tested this on 3.x didn't notice any issues with rendering. I didn't test the delta values. I was more interested to see if I can spot any glitches or issues that may negatively impact frame rendering. I thought at first that the rendering was more "slideshow"-y with this pr but tested again a number of times and visually is no different with than without the pr. |
71cb8d3 to
c58391c
Compare
The functions that used it already use a threadsafe FIFO queue to communicate between threads and a sync to have the main thread wait for the render thread. Fixes godotengine#35718
16fde22 to
9fbdace
Compare
Member
|
Force pushed a rebase. |
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The functions that used it already use a threadsafe FIFO queue
to communicate between threads and a sync to have the main thread
wait for the render thread.
Cherry-Picked from #35758, which is the same fix against the master branch (there have been renames)
Fixes #35718