Miscellaneous cleanup for the Android codebase#36798
Merged
akien-mga merged 1 commit intoMar 5, 2020
Merged
Conversation
- update gradle plugins versions - add formatting rules for AndroidManifest and gradle build files - cleanup java_godot_lib_jni Note: logic was mostly moved around and no new logic/functionality was added.
e1a30ff to
b38283a
Compare
Member
|
Thanks! |
Contributor
Author
|
@akien-mga Should I provide a separate version of this PR against the 3.2 branch? |
Member
|
No the |
Member
|
Actually this can't be cherry-picked easily for |
Contributor
Author
@akien-mga I've added PR #37300 as a dedicated PR for 3.2. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Miscellaneous cleanup for the Android codebase:
Note: logic was mostly moved around and no new logic/functionality was added.